Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1665635
| From | Marc Zyngier <marc.zyngier@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v7 3/3] PCI: Add tango MSI controller support |
| Date | 2017-06-14 11:40 +0200 |
| Message-ID | <tScWm-3r6-15@gated-at.bofh.it> (permalink) |
| References | (4 earlier) <tRUZr-Cj-5@gated-at.bofh.it> <tRViO-Jw-23@gated-at.bofh.it> <tRXkC-1WS-13@gated-at.bofh.it> <tSctj-3h2-11@gated-at.bofh.it> <tScMH-3nJ-33@gated-at.bofh.it> |
| Organization | ARM Ltd |
On 14/06/17 10:19, Marc Gonzalez wrote: > On 14/06/2017 11:00, Marc Gonzalez wrote: > >> The MSI controller in Tango supports 256 message-signaled interrupts, >> and a single doorbell address. >> >> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com> >> --- >> Changes from v6 to v7 >> o Call spin_lock() not spin_lock_irqsave() in the ISR >> --- >> drivers/pci/host/pcie-tango.c | 225 ++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 225 insertions(+) > > Someone on IRC suggested testing the driver with LOCKDEP. > > If I understand the warning below correctly, I am not supposed > to call irq_domain_set_info() while holding used_msi_lock? Indeed. This creates an AB/BA situation, which will eventually deadlock. Once again, lockdep saves the day. > NB: in probe, my driver calls > > add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK); > > This should not break LOCKDEP analysis, right? It doesn't. The code is provably wrong, and lockdep proved that it is wrong. M. -- Jazz is not dead. It just smells funny...
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v5 3/3] PCI: Add tango MSI controller support Marc Zyngier <marc.zyngier@arm.com> - 2017-06-13 14:20 +0200
[PATCH v6 3/3] PCI: Add tango MSI controller support Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2017-06-13 16:10 +0200
Re: [PATCH v6 3/3] PCI: Add tango MSI controller support Marc Zyngier <marc.zyngier@arm.com> - 2017-06-13 16:30 +0200
Re: [PATCH v6 3/3] PCI: Add tango MSI controller support Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2017-06-13 16:50 +0200
Re: [PATCH v6 3/3] PCI: Add tango MSI controller support Marc Zyngier <marc.zyngier@arm.com> - 2017-06-13 19:00 +0200
[PATCH v7 3/3] PCI: Add tango MSI controller support Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2017-06-14 11:10 +0200
Re: [PATCH v7 3/3] PCI: Add tango MSI controller support Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2017-06-14 11:30 +0200
Re: [PATCH v7 3/3] PCI: Add tango MSI controller support Marc Zyngier <marc.zyngier@arm.com> - 2017-06-14 11:40 +0200
[PATCH v8 3/3] PCI: Add tango MSI controller support Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2017-06-14 13:10 +0200
csiph-web