Re: [PATCH 07/18] spi: qup: Fix transaction done signaling

From	Sricharan R <sricharan@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 07/18] spi: qup: Fix transaction done signaling
Date	2017-06-14 09:20 +0200
Message-ID	<tSaKS-2aJ-17@gated-at.bofh.it> (permalink)
References	<tS9vs-1dT-7@gated-at.bofh.it> <tS9vw-1dT-47@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Varada,

On 6/14/2017 11:22 AM, Varadarajan Narayanan wrote:
> Wait to signal done until we get all of the interrupts we are expecting
> to get for a transaction.  If we don't wait for the input done flag, we
> can be inbetween transactions when the done flag comes in and this can
> mess up the next transaction.
> 
> Signed-off-by: Andy Gross <andy.gross@linaro.org>
> Signed-off-by: Varadarajan Narayanan <varada@codeaurora.org>
> ---
>  drivers/spi/spi-qup.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c
> index 2124815..7c22ee4 100644
> --- a/drivers/spi/spi-qup.c
> +++ b/drivers/spi/spi-qup.c
> @@ -465,7 +465,8 @@ static irqreturn_t spi_qup_qup_irq(int irq, void *dev_id)
>  	controller->xfer = xfer;
>  	spin_unlock_irqrestore(&controller->lock, flags);
>  
> -	if (controller->rx_bytes == xfer->len || error)
> +	if ((controller->rx_bytes == xfer->len &&
> +		(opflags & QUP_OP_MAX_INPUT_DONE_FLAG)) ||  error)

 Not sure why we need this additional check, because having read all the
 bytes implies transfer complete (or) why not just check only for
 QUP_OP_MAX_INPUT_DONE_FLAG ?

Regards,
 Sricharan

-- 
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

Thread

[PATCH 07/18] spi: qup: Fix transaction done signaling Varadarajan Narayanan <varada@codeaurora.org> - 2017-06-14 08:00 +0200
  Re: [PATCH 07/18] spi: qup: Fix transaction done signaling Sricharan R <sricharan@codeaurora.org> - 2017-06-14 09:20 +0200
    Re: [PATCH 07/18] spi: qup: Fix transaction done signaling Andy Gross <andy.gross@linaro.org> - 2017-06-14 22:00 +0200
      Re: [PATCH 07/18] spi: qup: Fix transaction done signaling Sricharan R <sricharan@codeaurora.org> - 2017-06-15 07:20 +0200

csiph-web