Re: [PATCH 1/3] ARM: Generalize fncpy implementation

From	Russell King - ARM Linux <linux@armlinux.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] ARM: Generalize fncpy implementation
Date	2017-06-16 14:00 +0200
Message-ID	<tSY4V-7Xg-1@gated-at.bofh.it> (permalink)
References	<tSMn7-tC-3@gated-at.bofh.it> <tSMn7-tC-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 15, 2017 at 04:21:15PM -0700, Florian Fainelli wrote:
> ARM's fncpy implementation is actually suitable for a large number of
> platforms since the only assumption it makes is just the function's
> alignment (8 bytes) which also happens to fulfil other architectures,
> including but not limited to ARM64.

NAK.  This is really not "generic" because the whole point of this is
that it encapsulates architecture specific knowledge - in the case of
ARM, the fact that bit 1 is used to indicate whether the code is to be
run in Thumb mode or ARM mode.

That clearly does not belong in an asm-generic version of this.

I'm not saying "don't provide an asm-generic" version, I'm saying don't
use the ARM version as an asm-generic implementation, because it is
nothing of the sort.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] ARM: Generalize fncpy implementation Florian Fainelli <f.fainelli@gmail.com> - 2017-06-16 01:30 +0200
  Re: [PATCH 1/3] ARM: Generalize fncpy implementation Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-06-16 14:00 +0200

csiph-web