Re: Re: [patch] mm, oom: prevent additional oom kills before memory is freed

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: Re: [patch] mm, oom: prevent additional oom kills before memory is freed
Date	2017-06-16 13:10 +0200
Message-ID	<tSXix-7EM-3@gated-at.bofh.it> (permalink)
References	<tSL7H-8eT-5@gated-at.bofh.it> <tSLhn-8i0-1@gated-at.bofh.it> <tSNMe-1h6-3@gated-at.bofh.it> <tSUXo-63M-11@gated-at.bofh.it> <tSWFQ-7co-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri 16-06-17 19:27:19, Tetsuo Handa wrote:
> Michal Hocko wrote:
> > On Fri 16-06-17 09:54:34, Tetsuo Handa wrote:
> > [...]
> > > And the patch you proposed is broken.
> > 
> > Thanks for your testing!
> >  
> > > ----------
> > > [  161.846202] Out of memory: Kill process 6331 (a.out) score 999 or sacrifice child
> > > [  161.850327] Killed process 6331 (a.out) total-vm:4172kB, anon-rss:84kB, file-rss:0kB, shmem-rss:0kB
> > > [  161.858503] ------------[ cut here ]------------
> > > [  161.861512] kernel BUG at mm/memory.c:1381!
> > 
> > BUG_ON(addr >= end) suggests our vma has trimmed. I guess I see what is
> > going on here.
> > __oom_reap_task_mm				exit_mmap
> > 						  free_pgtables
> > 						  up_write(mm->mmap_sem)
> >   down_read_trylock(&mm->mmap_sem)
> >   						  remove_vma
> >     unmap_page_range
> > 
> > So we need to extend the mmap_sem coverage. See the updated diff (not
> > the full proper patch yet).
> 
> That diff is still wrong. We need to prevent __oom_reap_task_mm() from calling
> unmap_page_range() when __mmput() already called exit_mm(), by setting/checking
> MMF_OOM_SKIP like shown below.

Care to explain why?
[...]
 
> Since the OOM reaper does not reap hugepages, khugepaged_exit() part could be
> safe.

I think you are mixing hugetlb and THP pages here. khugepaged_exit is
about later and we do unmap those.

> But ksm_exit() part might interfere.

How?

> If it is guaranteed to be safe,
> what will go wrong if we move uprobe_clear_state()/exit_aio()/ksm_exit() etc.
> to just before mmdrop() (i.e. after setting MMF_OOM_SKIP) ?

I do not see why those matter and why they should be any special. Unless
I miss anything we really do only care about page table tear down and
the address space modification. They do none of that.

-- 
Michal Hocko
SUSE Labs

Thread

[patch] mm, oom: prevent additional oom kills before memory is  freed David Rientjes <rientjes@google.com> - 2017-06-15 01:50 +0200
  Re: [patch] mm, oom: prevent additional oom kills before memory is  freed Michal Hocko <mhocko@kernel.org> - 2017-06-15 12:50 +0200
    Re: [patch] mm, oom: prevent additional oom kills before memory is freed Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-06-15 13:00 +0200
      Re: [patch] mm, oom: prevent additional oom kills before memory is  freed Michal Hocko <mhocko@kernel.org> - 2017-06-15 13:10 +0200
        Re: [patch] mm, oom: prevent additional oom kills before memory is freed Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-06-15 13:40 +0200
          Re: [patch] mm, oom: prevent additional oom kills before memory is  freed Michal Hocko <mhocko@kernel.org> - 2017-06-15 14:10 +0200
            Re: [patch] mm, oom: prevent additional oom kills before memory is  freed Michal Hocko <mhocko@kernel.org> - 2017-06-15 14:20 +0200
              Re: [patch] mm, oom: prevent additional oom kills before memory is freed Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-06-15 15:10 +0200
                Re: [patch] mm, oom: prevent additional oom kills before memory is  freed Michal Hocko <mhocko@kernel.org> - 2017-06-15 15:30 +0200
                Re: [patch] mm, oom: prevent additional oom kills before memory is freed Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-06-15 23:50 +0200
                Re: [patch] mm, oom: prevent additional oom kills before memory is  freed David Rientjes <rientjes@google.com> - 2017-06-15 23:40 +0200
        Re: [patch] mm, oom: prevent additional oom kills before memory is  freed Michal Hocko <mhocko@kernel.org> - 2017-06-15 14:30 +0200
    Re: [patch] mm, oom: prevent additional oom kills before memory is  freed David Rientjes <rientjes@google.com> - 2017-06-15 23:30 +0200
      Re: [patch] mm, oom: prevent additional oom kills before memory is  freed Michal Hocko <mhocko@kernel.org> - 2017-06-15 23:50 +0200
        Re: [patch] mm, oom: prevent additional oom kills before memory is  freed David Rientjes <rientjes@google.com> - 2017-06-16 00:10 +0200
          Re: [patch] mm, oom: prevent additional oom kills before memory is  freed Michal Hocko <mhocko@kernel.org> - 2017-06-16 00:20 +0200
            Re: [patch] mm, oom: prevent additional oom kills before memory is  freed David Rientjes <rientjes@google.com> - 2017-06-16 00:50 +0200
              Re: [patch] mm, oom: prevent additional oom kills before memory is  freed Michal Hocko <mhocko@kernel.org> - 2017-06-16 10:10 +0200
            Re: Re: [patch] mm, oom: prevent additional oom kills before memory is  freed Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> - 2017-06-16 03:00 +0200
              Re: [patch] mm, oom: prevent additional oom kills before memory is freed Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> - 2017-06-16 06:10 +0200
              Re: Re: [patch] mm, oom: prevent additional oom kills before memory  is freed Michal Hocko <mhocko@kernel.org> - 2017-06-16 10:40 +0200
                Re: Re: [patch] mm, oom: prevent additional oom kills before memory is freed Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-06-16 12:30 +0200
                Re: Re: [patch] mm, oom: prevent additional oom kills before memory  is freed Michal Hocko <mhocko@kernel.org> - 2017-06-16 13:10 +0200
                Re: Re: [patch] mm, oom: prevent additional oom kills before memoryis freed Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-06-16 16:30 +0200
                Re: Re: [patch] mm, oom: prevent additional oom kills before  memoryis freed Michal Hocko <mhocko@kernel.org> - 2017-06-16 16:50 +0200
                Re: Re: [patch] mm, oom: prevent additional oom kills before memory is freed Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-06-17 15:40 +0200
        Re: [patch] mm, oom: prevent additional oom kills before memory is freed Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-06-16 14:30 +0200
          Re: [patch] mm, oom: prevent additional oom kills before memory is  freed Michal Hocko <mhocko@kernel.org> - 2017-06-16 16:20 +0200
            [PATCH] mm,oom_kill: Close race window of needlessly selecting new victims. Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-06-17 07:20 +0200

csiph-web