Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1667605

Re: [PATCH] platform/x86: dell-laptop: Fix bogus keyboard backlight sysfs interface

Show all headers | View raw

On Fri, Jun 16, 2017 at 10:52 AM, Pali Rohár <pali.rohar@gmail.com> wrote:
> On Friday 16 June 2017 15:35:39 Kai-Heng Feng wrote:

>> -     if (kbd_token_bits != 0 || ret == 0)
>> +     /*
>> +      * If KBD_LED_OFF_TOKEN is the only token,
>> +      * consider there is no keyboard backlight.
>> +      */
>> +     if ((kbd_token_bits & ~BIT(5)) != 0 || ret == 0)
>
> Should not this check to be rather:
>
> (kbd_token_bits != 0 && (kbd_token_bits & BIT(KBD_LED_OFF_TOKEN)) != BIT(KBD_LED_OFF_TOKEN))
>
> To express that we have at least one token at it is different from
> KBD_LED_OFF_TOKEN token?

Isn't the same to

(kbd_token_bits ^ BIT(KBD_LED_OFF_TOKEN))

?

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] platform/x86: dell-laptop: Fix bogus keyboard backlight sysfs interface Kai-Heng Feng <kai.heng.feng@canonical.com> - 2017-06-16 09:40 +0200
  Re: [PATCH] platform/x86: dell-laptop: Fix bogus keyboard backlight  sysfs interface Pali Rohár <pali.rohar@gmail.com> - 2017-06-16 10:00 +0200
    Re: [PATCH] platform/x86: dell-laptop: Fix bogus keyboard backlight  sysfs interface Kai-Heng Feng <kai.heng.feng@canonical.com> - 2017-06-16 11:50 +0200
      Re: [PATCH] platform/x86: dell-laptop: Fix bogus keyboard backlight  sysfs interface Pali Rohár <pali.rohar@gmail.com> - 2017-06-16 12:10 +0200
    Re: [PATCH] platform/x86: dell-laptop: Fix bogus keyboard backlight  sysfs interface Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-16 12:10 +0200
  Re: [PATCH] platform/x86: dell-laptop: Fix bogus keyboard backlight  sysfs interface Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-18 14:50 +0200

csiph-web