Re: [PATCH 25/44] arm: implement ->mapping_error

From	Christoph Hellwig <hch@lst.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 25/44] arm: implement ->mapping_error
Date	2017-06-16 10:50 +0200
Message-ID	<tSV73-67Z-5@gated-at.bofh.it> (permalink)
References	<tQ5FE-4OD-5@gated-at.bofh.it> <tQ5Pk-4SX-23@gated-at.bofh.it> <tQ6V4-5vT-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 08, 2017 at 03:43:14PM +0100, Russell King - ARM Linux wrote:
> BOn Thu, Jun 08, 2017 at 03:25:50PM +0200, Christoph Hellwig wrote:
> > +static int dmabounce_mapping_error(struct device *dev, dma_addr_t dma_addr)
> > +{
> > +	if (dev->archdata.dmabounce)
> > +		return 0;
> 
> I'm not convinced that we need this check here:
> 
>         dev->archdata.dmabounce = device_info;
>         set_dma_ops(dev, &dmabounce_ops);
> 
> There shouldn't be any chance of dev->archdata.dmabounce being NULL if
> the dmabounce_ops has been set as the current device DMA ops.  So I
> think that test can be killed.

Ok, I'll fix it up.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 25/44] arm: implement ->mapping_error Christoph Hellwig <hch@lst.de> - 2017-06-08 15:40 +0200
  Re: [PATCH 25/44] arm: implement ->mapping_error Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-06-08 16:50 +0200
    Re: [PATCH 25/44] arm: implement ->mapping_error Christoph Hellwig <hch@lst.de> - 2017-06-16 10:50 +0200

csiph-web