Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1667509

Re: [PATCH] omap3isp: fix compilation

From Hans Verkuil <hverkuil@xs4all.nl>
Newsgroups linux.kernel
Subject Re: [PATCH] omap3isp: fix compilation
Date 2017-06-16 10:10 +0200
Message-ID <tSUul-5Te-1@gated-at.bofh.it> (permalink)
References (6 earlier) <tRT7k-7UN-33@gated-at.bofh.it> <tRTqG-81T-11@gated-at.bofh.it> <tS1ez-4Bs-51@gated-at.bofh.it> <tSelr-4qx-3@gated-at.bofh.it> <tSLr4-8li-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 06/16/2017 12:23 AM, Pavel Machek wrote:
> 
> Fix compilation of isp.c
>      
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
> 
> diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c
> index 4ca3fc9..b80debf 100644
> --- a/drivers/media/platform/omap3isp/isp.c
> +++ b/drivers/media/platform/omap3isp/isp.c
> @@ -2026,7 +2026,7 @@ static int isp_fwnode_parse(struct device *dev, struct fwnode_handle *fwnode,
>   
>   	isd->bus = buscfg;
>   
> -	ret = v4l2_fwnode_endpoint_parse(fwn, vep);
> +	ret = v4l2_fwnode_endpoint_parse(fwnode, &vep);
>   	if (ret)
>   		return ret;
>   
> 

You're using something old since the media tree master already uses &vep.

Regards,

	Hans

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

v4l2-fwnode: status, plans for merge, any branch to merge against? Pavel Machek <pavel@ucw.cz> - 2017-06-13 14:30 +0200
  Re: v4l2-fwnode: status, plans for merge, any branch to merge  against? Sakari Ailus <sakari.ailus@iki.fi> - 2017-06-13 14:50 +0200
    Re: v4l2-fwnode: status, plans for merge, any branch to merge  against? Pavel Machek <pavel@ucw.cz> - 2017-06-13 23:10 +0200
      Re: v4l2-fwnode: status, plans for merge, any branch to merge  against? Sakari Ailus <sakari.ailus@iki.fi> - 2017-06-14 13:10 +0200
        Re: v4l2-fwnode: status, plans for merge, any branch to merge  against? Pavel Machek <pavel@ucw.cz> - 2017-06-14 21:50 +0200
          Re: v4l2-fwnode: status, plans for merge, any branch to merge  against? Sakari Ailus <sakari.ailus@iki.fi> - 2017-06-16 00:10 +0200
            Re: v4l2-fwnode: status, plans for merge, any branch to merge  against? Pavel Machek <pavel@ucw.cz> - 2017-06-16 08:30 +0200
        [PATCH] omap3isp: fix compilation Pavel Machek <pavel@ucw.cz> - 2017-06-16 00:30 +0200
          Re: [PATCH] omap3isp: fix compilation Hans Verkuil <hverkuil@xs4all.nl> - 2017-06-16 10:10 +0200
            Re: [PATCH] omap3isp: fix compilation Sakari Ailus <sakari.ailus@iki.fi> - 2017-06-16 14:10 +0200
        n900 camera on v4.12-rc (was Re: v4l2-fwnode: status, plans for  merge, any branch to merge against?) Pavel Machek <pavel@ucw.cz> - 2017-06-16 00:30 +0200

csiph-web