Re: [PATCH 5/5] phy: bcm-ns-usb3: add MDIO driver using proper bus layer

From	Kishon Vijay Abraham I <kishon@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/5] phy: bcm-ns-usb3: add MDIO driver using proper bus layer
Date	2017-06-16 08:40 +0200
Message-ID	<tST5g-4Rd-11@gated-at.bofh.it> (permalink)
References	<tFWtY-6Ru-13@gated-at.bofh.it> <tFWtY-6Ru-25@gated-at.bofh.it> <tFZia-ha-21@gated-at.bofh.it> <tSSCd-4Hk-9@gated-at.bofh.it> <tSSLT-4KG-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Rafal,

On Friday 16 June 2017 11:41 AM, Rafał Miłecki wrote:
> On 16 June 2017 at 08:04, Kishon Vijay Abraham I <kishon@ti.com> wrote:
>> On Thursday 11 May 2017 09:59 PM, Florian Fainelli wrote:
>>> On 05/11/2017 06:29 AM, Rafał Miłecki wrote:
>>>> @@ -297,6 +371,28 @@ static struct platform_driver bcm_ns_usb3_driver = {
>>>>              .of_match_table = bcm_ns_usb3_id_table,
>>>>      },
>>>>  };
>>>> -module_platform_driver(bcm_ns_usb3_driver);
>>>> +
>>>> +static int __init bcm_ns_usb3_module_init(void)
>>>> +{
>>>> +    int err;
>>>> +
>>>> +    err = mdio_driver_register(&bcm_ns_usb3_mdio_driver);
>>>> +    if (err)
>>>> +            return err;
>>>> +
>>>> +    err = platform_driver_register(&bcm_ns_usb3_driver);
>>>> +    if (err)
>>>> +            mdio_driver_unregister(&bcm_ns_usb3_mdio_driver);
>>>> +
>>>> +    return err;
>>>> +}
>>>> +module_init(bcm_ns_usb3_module_init);
>>>> +
>>>> +static void __exit bcm_ns_usb3_module_exit(void)
>>>> +{
>>>> +    platform_driver_unregister(&bcm_ns_usb3_driver);
>>>> +    mdio_driver_unregister(&bcm_ns_usb3_mdio_driver);
>>>> +}
>>>> +module_exit(bcm_ns_usb3_module_exit)
>>>
>>> Do we need to keep both platform device and mdio device registration
>>> here? Do you have a depreciation time line for when we can entirely
>>> switch to mdio device (assuming this is for backwards compatibility)?
>>
>> I too have the same question.
> 
> My plan is to:
> 1) Get this patch accepted
> 2) Switch DTS files to use the new binding
> 3) Maybe wait for LTS release if we care that much
> 4) Drop old binding support

old dt's are generally not allowed to break. So I'm not sure if we shoud ever
drop old binding support. Rest sounds good.

Thanks
Kishon

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 5/5] phy: bcm-ns-usb3: add MDIO driver using proper bus  layer Kishon Vijay Abraham I <kishon@ti.com> - 2017-06-16 08:10 +0200
  Re: [PATCH 5/5] phy: bcm-ns-usb3: add MDIO driver using proper bus layer Rafał Miłecki <zajec5@gmail.com> - 2017-06-16 08:20 +0200
    Re: [PATCH 5/5] phy: bcm-ns-usb3: add MDIO driver using proper bus  layer Kishon Vijay Abraham I <kishon@ti.com> - 2017-06-16 08:40 +0200

csiph-web