Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1667383

Re: [PATCH] kbuild: fix header installation under fakechroot environment

Show all headers | View raw

Hi Richard,


2017-06-15 17:36 GMT+09:00 Richard Genoud <richard.genoud@gmail.com>:
> Since commit fcc8487d477a ("uapi: export all headers under uapi
> directories") fakechroot make bindeb-pkg fails, mismatching files for
> directories:
> touch: cannot touch 'usr/include/video/uvesafb.h/.install': Not a
> directory
>
> This due to a bug in fakechroot:
> when using the function $(wildcard $(srcdir)/*/.) in a makefile, under a
> fakechroot environment, not only directories but also files are
> returned.
>
> To circumvent that, we are using the functions:
> $(sort $(dir $(wildcard $(srcdir)/*/))))
>
> And thanks to Yamada Masahiro who figured out the right
> filter-out/patsubst order !

Sorry if I confused you.

The order of filter-out/patsubst was not a real problem,
but just a matter of taste.

Your original code used $(filter-out ./, ...),
but this could not filter out anything.  This is the root cause.

I will remove this paragraph because it is even confusing.

Thanks for the credit, but it is regular review process,
so it is not mandatory in git-log.  :-)


I will pick up this patch shortly anyway.




-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] kbuild: fix header installation under fakechroot environment Richard Genoud <richard.genoud@gmail.com> - 2017-06-15 10:40 +0200
  Re: [PATCH] kbuild: fix header installation under fakechroot environment Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-16 04:30 +0200

csiph-web