Re: [Intel-wired-lan] [PATCH] intel: i40e: virtchnl: fix incorrect variable assignment

From	"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Newsgroups	linux.kernel
Subject	Re: [Intel-wired-lan] [PATCH] intel: i40e: virtchnl: fix incorrect variable assignment
Date	2017-06-15 23:10 +0200
Message-ID	<tSKbD-7DA-3@gated-at.bofh.it> (permalink)
References	<tSsRr-52d-1@gated-at.bofh.it> <tSK1Y-7lg-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Jesse,

Quoting Jesse Brandeburg <jesse.brandeburg@intel.com>:

> On Wed, 14 Jun 2017 21:38:26 -0500
> "Gustavo A. R. Silva" <garsilva@embeddedor.com> wrote:
>
>> Fix incorrect variable assignment.
>> Based on line 1511: aq_ret = I40_ERR_PARAM; the correct variable to be
>> used in this instance is aq_ret instead of ret. Also, variable ret is
>> updated at line 1602 just before return, so assigning a value to this
>> variable in this code block is useless.
>>
>> Addresses-Coverity-ID: 1397693
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>
> Thanks for the fix, looks reasonable.
> Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>

Absolutely, glad to help.

Regards
--
Gustavo A. R. Silva

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] intel: i40e: virtchnl: fix incorrect variable assignment "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-15 04:40 +0200
  Re: [Intel-wired-lan] [PATCH] intel: i40e: virtchnl: fix incorrect  variable assignment Jesse Brandeburg <jesse.brandeburg@intel.com> - 2017-06-15 23:00 +0200
    Re: [Intel-wired-lan] [PATCH] intel: i40e: virtchnl: fix incorrect  variable assignment "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-15 23:10 +0200

csiph-web