Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1667180

Re: [PATCH net-next] net: dsa: assign default CPU port to all ports

Show all headers | View raw

On 06/15/2017 12:06 PM, Vivien Didelot wrote:
> The current code only assigns the default cpu_dp to all user ports of
> the switch to which the CPU port belongs. The user ports of the other
> switches of the fabric thus don't have a default CPU port.

Which would lead to a crash in dsa_master_netdev() :)

> 
> This patch fixes this by assigning the cpu_dp of all user ports of all
> switches of the fabric when the tree is fully parsed.
> 
> Fixes: a29342e73911 ("net: dsa: Associate slave network device with CPU port")
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>

Thanks for this fix:

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next] net: dsa: assign default CPU port to all ports Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-06-15 21:10 +0200
  Re: [PATCH net-next] net: dsa: assign default CPU port to all ports Florian Fainelli <f.fainelli@gmail.com> - 2017-06-15 21:20 +0200
  Re: [PATCH net-next] net: dsa: assign default CPU port to all ports David Miller <davem@davemloft.net> - 2017-06-15 23:30 +0200

csiph-web