[PATCH] drm/msm/hdmi: Use bitwise operators when building register values

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Liviu Dudau <Liviu.Dudau@arm.com>
Newsgroups	linux.kernel
Subject	[PATCH] drm/msm/hdmi: Use bitwise operators when building register values
Date	Thu, 15 Jun 2017 16:20:02 +0200
Message-ID	<tSDMS-3vs-15@gated-at.bofh.it> (permalink)
X-Original-To	Rob Clark <robdclark@gmail.com>
X-Mailer	git-send-email 2.13.1
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	31
Organization	linux.* mail to news gateway
X-Original-Cc	David Airlie <airlied@linux.ie>, LAM <linux-arm-msm@vger.kernel.org>, DRI devel <dri-devel@lists.freedesktop.org>, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Liviu Dudau <liviu.dudau@arm.com>
X-Original-Date	Thu, 15 Jun 2017 15:13:46 +0100
X-Original-Message-ID	<20170615141346.12859-1-Liviu.Dudau@arm.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1666754

Show key headers only | View raw

Commit c0c0d9eeeb8d ("drm/msm: hdmi audio support") uses logical
OR operators to build up a value to be written in the
REG_HDMI_AUDIO_INFO0 and REG_HDMI_AUDIO_INFO1 registers when it
should have used bitwise operators.

Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
Fixes: c0c0d9eeeb8d ("drm/msm: hdmi audio support")
---
 drivers/gpu/drm/msm/hdmi/hdmi_audio.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_audio.c b/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
index 8177e8511afd..9c34b91ae329 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
@@ -175,10 +175,10 @@ int msm_hdmi_audio_update(struct hdmi *hdmi)
 		/* configure infoframe: */
 		hdmi_audio_infoframe_pack(info, buf, sizeof(buf));
 		hdmi_write(hdmi, REG_HDMI_AUDIO_INFO0,
-				(buf[3] <<  0) || (buf[4] <<  8) ||
-				(buf[5] << 16) || (buf[6] << 24));
+				(buf[3] <<  0) | (buf[4] <<  8) |
+				(buf[5] << 16) | (buf[6] << 24));
 		hdmi_write(hdmi, REG_HDMI_AUDIO_INFO1,
-				(buf[7] <<  0) || (buf[8] << 8));
+				(buf[7] <<  0) | (buf[8] << 8));
 
 		hdmi_write(hdmi, REG_HDMI_GC, 0);
 
-- 
2.13.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] drm/msm/hdmi: Use bitwise operators when building register values Liviu Dudau <Liviu.Dudau@arm.com> - 2017-06-15 16:20 +0200

csiph-web