Re: [PATCH] objtool: Add fortify_panic as __noreturn function

From	Josh Poimboeuf <jpoimboe@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] objtool: Add fortify_panic as __noreturn function
Date	2017-06-15 15:20 +0200
Message-ID	<tSCQN-2X8-1@gated-at.bofh.it> (permalink)
References	<tSsy5-4W0-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 14, 2017 at 07:18:51PM -0700, Kees Cook wrote:
> CONFIG_FORTIFY_SOURCE implements fortify_panic() as a __noreturn function,
> so objtool needs to know about it too.
> 
> Suggested-by: Daniel Micay <danielmicay@gmail.com>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> Cc: Josh Poimboeuf <jpoimboe@redhat.com>
> ---
>  tools/objtool/builtin-check.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/objtool/builtin-check.c b/tools/objtool/builtin-check.c
> index 282a60368b14..5f66697fe1e0 100644
> --- a/tools/objtool/builtin-check.c
> +++ b/tools/objtool/builtin-check.c
> @@ -192,7 +192,8 @@ static int __dead_end_function(struct objtool_file *file, struct symbol *func,
>  		"complete_and_exit",
>  		"kvm_spurious_fault",
>  		"__reiserfs_panic",
> -		"lbug_with_loc"
> +		"lbug_with_loc",
> +		"fortify_panic",
>  	};
>  
>  	if (func->bind == STB_WEAK)

Thanks, I'll take the patch.

Eventually I'd like to experiment with a GCC plugin to automatically
detect these noreturn cases instead of the hard-coded list.

-- 
Josh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] objtool: Add fortify_panic as __noreturn function Kees Cook <keescook@chromium.org> - 2017-06-15 04:20 +0200
  Re: [PATCH] objtool: Add fortify_panic as __noreturn function Stephen Rothwell <sfr@canb.auug.org.au> - 2017-06-15 06:10 +0200
    Re: [PATCH] objtool: Add fortify_panic as __noreturn function Stephen Rothwell <sfr@canb.auug.org.au> - 2017-06-15 06:30 +0200
      Re: [PATCH] objtool: Add fortify_panic as __noreturn function Daniel Micay <danielmicay@gmail.com> - 2017-06-15 06:50 +0200
        Re: [PATCH] objtool: Add fortify_panic as __noreturn function Stephen Rothwell <sfr@canb.auug.org.au> - 2017-06-15 07:10 +0200
  Re: [PATCH] objtool: Add fortify_panic as __noreturn function Stephen Rothwell <sfr@canb.auug.org.au> - 2017-06-15 07:10 +0200
  Re: [PATCH] objtool: Add fortify_panic as __noreturn function Josh Poimboeuf <jpoimboe@redhat.com> - 2017-06-15 15:20 +0200

csiph-web