Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1665469
| Path | csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | [PATCH] usb: host: ohci-pxa27x: Handle return value of clk_prepare_enable |
| Date | Wed, 14 Jun 2017 08:10:01 +0200 |
| Message-ID | <tS9F7-1we-9@gated-at.bofh.it> (permalink) |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=GsU1e97XS8Z5eIyG6fiZUvhPIXqn0re5JJzqVLrsJBQ=; b=lckc15YbBb8ao29jINr0ZFZLJ0AFBwkX4c3S2gi03Yx+ZbWnKl/j1rfT63yccYzZHi r9xJMKaLkvk42SLtacIN8D/x9GWnxX3N4Y4vs5HotxKuFgdG6CiksoRfiPi/Zh32Is5e 4oVAyo6KoVTy0N9OuCMqNeDr4GbXd/ZxUVAvCV+xQ9EwmNcoQX0WCZRHBHTCxeOWOkEB C5dGkpSKxMieYl8UvzUZC0rXNPYTCXVZOm2mWS1/qPOt3x317iHUpiZ6F83Iaf0vlnAG SzYWDffRe7qzyAF6XMh4mHFGIQR8CnL4w3r9s1KJqPEBJe/K5lmzoB2xvWdW8cggL0cL 483g== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=GsU1e97XS8Z5eIyG6fiZUvhPIXqn0re5JJzqVLrsJBQ=; b=s6vtOiCMR4CDimxfoS1CynzBDlLPBaG4IveaR45xTDwtYYQ/rOjf7UwVm71APGfldK 3VhXlU2zWNnA1IuMAKWxuGNlkPVBdvy6wLED0aPMq0FMIn+1klcJomxkFenUaVfvfhTH isOSGqcu8OR74XeWa7homX7vVSqYni1xEENTzYT3isXiJNUty4Guz/W1Y0z6vrh/BSoX H0wFXYISAPnS0D6UMFfmdNprSVQmm++gOACBbiukpniqF8Not/m8113XeA+NhKkEo5Ad +woytDUQAnHWFD1Vnx+N94IvAzzXYVrj+gk+UKjHxeT7DrRTmCLlvlBCZYFOX012DMXh zW3A== |
| X-Gm-Message-State | AKS2vOyqB8m8JNzHBWARH4H++rxmXQ9xqIBkJ9EyYIYz39LQm1vTDgQd itc5L0oQh0CdSg== |
| X-Received | by 10.84.241.73 with SMTP id u9mr3243092plm.30.1497420174325; Tue, 13 Jun 2017 23:02:54 -0700 (PDT) |
| X-Mailer | git-send-email 1.9.1 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 36 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Wed, 14 Jun 2017 11:32:22 +0530 |
| X-Original-Message-ID | <9adc506aa3b14033472a7a473d842962d155e005.1497419972.git.arvind.yadav.cs@gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1665469 |
Show key headers only | View raw
clk_prepare_enable() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/usb/host/ohci-pxa27x.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci-pxa27x.c
index 79efde8f..c5afdb2 100644
--- a/drivers/usb/host/ohci-pxa27x.c
+++ b/drivers/usb/host/ohci-pxa27x.c
@@ -281,7 +281,9 @@ static int pxa27x_start_hc(struct pxa27x_ohci *pxa_ohci, struct device *dev)
inf = dev_get_platdata(dev);
- clk_prepare_enable(pxa_ohci->clk);
+ retval = clk_prepare_enable(pxa_ohci->clk);
+ if (retval)
+ return retval;
pxa27x_reset_hc(pxa_ohci);
@@ -296,8 +298,10 @@ static int pxa27x_start_hc(struct pxa27x_ohci *pxa_ohci, struct device *dev)
if (inf->init)
retval = inf->init(dev);
- if (retval < 0)
+ if (retval < 0) {
+ clk_disable_unprepare(pxa_ohci->clk);
return retval;
+ }
if (cpu_is_pxa3xx())
pxa3xx_u2d_start_hc(&hcd->self);
--
1.9.1
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] usb: host: ohci-pxa27x: Handle return value of clk_prepare_enable Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-14 08:10 +0200 Re: [PATCH] usb: host: ohci-pxa27x: Handle return value of clk_prepare_enable Alan Stern <stern@rowland.harvard.edu> - 2017-06-14 16:40 +0200
csiph-web