Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1665428
| From | Peter Dawson <petedaws@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] ip6_tunnel: Correct tos value in collect_md mode |
| Date | 2017-06-14 07:30 +0200 |
| Message-ID | <tS92q-11P-1@gated-at.bofh.it> (permalink) |
| References | <tS6xz-7Me-3@gated-at.bofh.it> <tS6Hf-7QQ-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, 14 Jun 2017 10:54:31 +0800 严海双 <yanhaishuang@cmss.chinamobile.com> wrote: > > Changes since v2: > > * mask key->tos with RT_TOS() suggested by Daniel Can you help me understand the rationale for this change? Is there are bug introduced by dsfield = ip6_tclass(key->label); ? The RT_TOS masks out 4bits of the 8bit tos field in accordance with RFC1349 (obsoleted by RFC2474). IPv6 does not have a TOS field. So it dosen't make sense to apply a TOS value to the outer header of an IPv6 tunnel.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] ip6_tunnel: Correct tos value in collect_md mode Haishuang Yan <yanhaishuang@cmss.chinamobile.com> - 2017-06-14 04:50 +0200
Re: [PATCH] ip6_tunnel: Correct tos value in collect_md mode 严海双 <yanhaishuang@cmss.chinamobile.com> - 2017-06-14 05:00 +0200
Re: [PATCH] ip6_tunnel: Correct tos value in collect_md mode Peter Dawson <petedaws@gmail.com> - 2017-06-14 07:30 +0200
Re: [PATCH] ip6_tunnel: Correct tos value in collect_md mode 严海双 <yanhaishuang@cmss.chinamobile.com> - 2017-06-15 03:00 +0200
csiph-web