Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1665362

Re: [PATCH v4 12/16] perf header: add a buffer to struct feat_fd

Show all headers | View raw

On Tue, Jun 13, 2017 at 11:54 AM, Jiri Olsa <jolsa@redhat.com> wrote:
> On Mon, Jun 12, 2017 at 09:29:28PM -0700, David Carrillo-Cisneros wrote:
>
> SNIP
>
>>  /* Return: 0 if succeded, -ERR if failed. */
>>  int write_padded(struct feat_fd *ff, const void *bf,
>>                size_t count, size_t count_aligned)
>> @@ -125,13 +151,32 @@ static int do_write_string(struct feat_fd *ff, const char *str)
>>       return write_padded(ff, str, olen, len);
>>  }
>>
>> -static int __do_read(struct feat_fd *ff, void *addr, ssize_t size)
>> +static int __do_read_fd(struct feat_fd *ff, void *addr, ssize_t size)
>>  {
>> -     ssize_t ret = readn(ff->fd, addr, size);
>> +             ssize_t ret = readn(ff->fd, addr, size);
>> +
>> +             if (ret != size)
>> +                     return ret < 0 ? (int)ret : -1;
>> +             return 0;
>
> extra tab in indent

fixed

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 00/16] perf tool: add meta-data header support for pipe-mode David Carrillo-Cisneros <davidcc@google.com> - 2017-06-13 06:40 +0200
  [PATCH v4 16/16] perf header: add event desc to pipe-mode header David Carrillo-Cisneros <davidcc@google.com> - 2017-06-13 06:40 +0200
  [PATCH v4 03/16] perf header: fail on write_padded error David Carrillo-Cisneros <davidcc@google.com> - 2017-06-13 06:40 +0200
  [PATCH v4 13/16] perf header: change FEAT_OP* macros David Carrillo-Cisneros <davidcc@google.com> - 2017-06-13 06:40 +0200
  [PATCH v4 02/16] perf header: add PROCESS_STR_FUN macro David Carrillo-Cisneros <davidcc@google.com> - 2017-06-13 06:40 +0200
  [PATCH v4 10/16] perf header: use struct feat_fd in read header records David Carrillo-Cisneros <davidcc@google.com> - 2017-06-13 06:40 +0200
  [PATCH v4 07/16] perf header: use struct feat_fd for print David Carrillo-Cisneros <davidcc@google.com> - 2017-06-13 06:40 +0200
  [PATCH v4 01/16] perf header: encapsulate read and swap David Carrillo-Cisneros <davidcc@google.com> - 2017-06-13 06:40 +0200
  [PATCH v4 04/16] perf util: add const modifier to buf in "writen" function David Carrillo-Cisneros <davidcc@google.com> - 2017-06-13 06:40 +0200
  [PATCH v4 11/16] perf header: make write_pmu_mappings pipe-mode friendly David Carrillo-Cisneros <davidcc@google.com> - 2017-06-13 06:40 +0200
  [PATCH v4 09/16] perf header: don't pass struct perf_file_section to process_##_feat David Carrillo-Cisneros <davidcc@google.com> - 2017-06-13 06:40 +0200
    Re: [PATCH v4 09/16] perf header: don't pass struct  perf_file_section to process_##_feat Jiri Olsa <jolsa@redhat.com> - 2017-06-13 21:00 +0200
      Re: [PATCH v4 09/16] perf header: don't pass struct perf_file_section  to process_##_feat David Carrillo-Cisneros <davidcc@google.com> - 2017-06-14 04:00 +0200
  [PATCH v4 12/16] perf header: add a buffer to struct feat_fd David Carrillo-Cisneros <davidcc@google.com> - 2017-06-13 06:40 +0200
    Re: [PATCH v4 12/16] perf header: add a buffer to struct feat_fd Jiri Olsa <jolsa@redhat.com> - 2017-06-13 21:00 +0200
      Re: [PATCH v4 12/16] perf header: add a buffer to struct feat_fd David Carrillo-Cisneros <davidcc@google.com> - 2017-06-14 04:00 +0200
  [PATCH v4 14/16] perf tool: add show_feature_header to perf_tool David Carrillo-Cisneros <davidcc@google.com> - 2017-06-13 06:40 +0200
    Re: [PATCH v4 14/16] perf tool: add show_feature_header to perf_tool Jiri Olsa <jolsa@redhat.com> - 2017-06-13 21:00 +0200
  [PATCH v4 06/16] perf header: add struct feat_fd for write David Carrillo-Cisneros <davidcc@google.com> - 2017-06-13 06:40 +0200
  [PATCH v4 08/16] perf header: use struct feat_fd to process header records David Carrillo-Cisneros <davidcc@google.com> - 2017-06-13 06:40 +0200
  Re: [PATCH v4 00/16] perf tool: add meta-data header support for  pipe-mode Jiri Olsa <jolsa@redhat.com> - 2017-06-13 21:00 +0200
    Re: [PATCH v4 00/16] perf tool: add meta-data header support for pipe-mode David Carrillo-Cisneros <davidcc@google.com> - 2017-06-14 08:50 +0200
  Re: [PATCH v4 00/16] perf tool: add meta-data header support for  pipe-mode Jiri Olsa <jolsa@redhat.com> - 2017-06-13 21:00 +0200
    Re: [PATCH v4 00/16] perf tool: add meta-data header support for pipe-mode David Carrillo-Cisneros <davidcc@google.com> - 2017-06-14 09:00 +0200
      Re: [PATCH v4 00/16] perf tool: add meta-data header support for  pipe-mode Jiri Olsa <jolsa@redhat.com> - 2017-06-14 09:30 +0200
        Re: [PATCH v4 00/16] perf tool: add meta-data header support for pipe-mode David Carrillo-Cisneros <davidcc@google.com> - 2017-06-14 20:40 +0200

csiph-web