Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1665231

Re: [PATCH v5 0/4] of: remove *phandle properties from expanded device tree

Show all headers | View raw

On Sat, Jun 10, 2017 at 12:47 AM,  <frowand.list@gmail.com> wrote:
> From: Frank Rowand <frank.rowand@sony.com>
>
> Remove "phandle" and "linux,phandle" properties from the internal
> device tree.  The phandle will still be in the struct device_node
> phandle field.
>
> This is to resolve the issue found by Stephen Boyd [1] when he changed
> the type of struct property.value from void * to const void *.  As
> a result of the type change, the overlay code had compile errors
> where the resolver updates phandle values.
>
>   [1] http://lkml.iu.edu/hypermail/linux/kernel/1702.1/04160.html
>
> Patch 1 is the phandle related changes.
>
> Patches 2 - 4 are minor fixups for issues that became visible
> while implementing patch 1.
>
> Changes from v4:
>    - rebase on 4.12-rc1
>    - Add reason for "<NULL>" in of_attach_node()
>    - Simplify and consolidate phandle detection logic in
>      populate_properties().  This results in a change of behaviour,
>      the value of property "ibm,phandle" will no longer override the
>      value of properties "phandle" and "linux,phandle".
>
> Changes from v3:
>    - patch 1: fix incorrect variable name in __of_add_phandle_sysfs().
>      Problem was reported by the kbuild test robot
>
> Changes from v2:
>    - patch 1: Remove check in __of_add_phandle_sysfs() that would not
>      add a sysfs entry if IS_ENABLED(CONFIG_PPC_PSERIES)
>
> Changes from v1:
>    - Remove phandle properties in of_attach_node(), before attaching
>      the node to the live tree.
>    - Add the phandle sysfs entry for the node in of_attach_node().
>    - When creating an overlay changeset, duplicate the node phandle in
>      __of_node_dup().
>
> Frank Rowand (4):
>   of: remove *phandle properties from expanded device tree
>   of: make __of_attach_node() static
>   of: be consistent in form of file mode
>   of: detect invalid phandle in overlay
>
>  drivers/of/base.c       | 50 +++++++++++++++++++++++++++++++++++++++----
>  drivers/of/dynamic.c    | 57 +++++++++++++++++++++++++++++++++++++------------
>  drivers/of/fdt.c        | 43 ++++++++++++++++++-------------------
>  drivers/of/of_private.h |  2 +-
>  drivers/of/overlay.c    |  8 ++++---
>  drivers/of/resolver.c   | 23 +-------------------
>  include/linux/of.h      |  1 +
>  7 files changed, 118 insertions(+), 66 deletions(-)

Series applied.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 0/4] of: remove *phandle properties from expanded device tree frowand.list@gmail.com - 2017-06-10 07:50 +0200
  [PATCH v5 3/4] of: be consistent in form of file mode frowand.list@gmail.com - 2017-06-10 07:50 +0200
  [PATCH v5 1/4] of: remove *phandle properties from expanded device tree frowand.list@gmail.com - 2017-06-10 07:50 +0200
    Re: [PATCH v5 1/4] of: remove *phandle properties from expanded device tree Michael Ellerman <mpe@ellerman.id.au> - 2017-06-15 09:00 +0200
  [PATCH v5 4/4] of: detect invalid phandle in overlay frowand.list@gmail.com - 2017-06-10 07:50 +0200
  [PATCH v5 2/4] of: make __of_attach_node() static frowand.list@gmail.com - 2017-06-10 07:50 +0200
  Re: [PATCH v5 0/4] of: remove *phandle properties from expanded  device tree Rob Herring <robh+dt@kernel.org> - 2017-06-14 00:10 +0200
  Re: [PATCH v5 0/4] of: remove *phandle properties from expanded  device tree Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2017-06-16 02:10 +0200
    Re: [PATCH v5 0/4] of: remove *phandle properties from expanded  device tree Frank Rowand <frowand.list@gmail.com> - 2017-06-16 03:40 +0200

csiph-web