Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1665155

Re: [PATCH] af_iucv: Move sockaddr length checks to before accessing sa_family in bind and connect handlers

Show all headers | View raw

From: Mateusz Jurczyk <mjurczyk@google.com>
Date: Tue, 13 Jun 2017 19:42:28 +0200

> Verify that the caller-provided sockaddr structure is large enough to
> contain the sa_family field, before accessing it in bind() and connect()
> handlers of the AF_IUCV socket. Since neither syscall enforces a minimum
> size of the corresponding memory region, very short sockaddrs (zero or
> one byte long) result in operating on uninitialized memory while
> referencing .sa_family.
> 
> Signed-off-by: Mateusz Jurczyk <mjurczyk@google.com>
...
>  	/* Verify the input sockaddr */
> -	if (!addr || addr->sa_family != AF_IUCV)
> -		return -EINVAL;
> -
> -	if (addr_len < sizeof(struct sockaddr_iucv))
> +	if (!addr || addr_len < sizeof(struct sockaddr_iucv) ||
> +	    addr->sa_family != AF_IUCV)

The 'addr' can never be NULL so please remove that check, thank you.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] af_iucv: Move sockaddr length checks to before accessing sa_family in bind and connect handlers Mateusz Jurczyk <mjurczyk@google.com> - 2017-06-13 19:50 +0200
  Re: [PATCH] af_iucv: Move sockaddr length checks to before  accessing sa_family in bind and connect handlers David Miller <davem@davemloft.net> - 2017-06-13 22:20 +0200
  Re: [PATCH] af_iucv: Move sockaddr length checks to before accessing  sa_family in bind and connect handlers Julian Wiedmann <jwi@linux.vnet.ibm.com> - 2017-06-14 17:00 +0200

csiph-web