Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1665173

Re: [RESEND x3][PATCH v4] arm64: dts: hi6220: Add k3-dma and i2s/hdmi audio support

Show all headers | View raw

On Tue, Jun 13, 2017 at 1:16 PM, Mark Brown <broonie@kernel.org> wrote:
> On Tue, Jun 13, 2017 at 12:57:44PM -0700, John Stultz wrote:
>> On Tue, Jun 13, 2017 at 12:54 PM, Mark Brown <broonie@kernel.org> wrote:
>> > On Tue, Jun 13, 2017 at 12:40:28PM -0700, John Stultz wrote:
>
>> >> The simple-audio-card bindings are still valid, so maybe could we
>> >> merge the proposed dts change I've submitted and then look at
>> >> migrating over to the audio-card-graph once the dependencies are all
>> >> in place?
>
>> > Which dependencies sorry?
>
>> So the adv7511 driver needs to add a .get_dai_id() hook to renumber
>> the port to dai id.
>
> Oh, that should be pretty trivial though?  Especially given that it
> seems like it's been difficult to get DT changes to this platform merged
> I'm a bit nervous about the followup here.

Its a trivial bit of code, but its in the drm directory and I suspect
at this stage I'm not going to be able to get maintainer attention for
it in time for 4.13 (plus since it depends on things in the ASoC tree,
so it needs cross-maintainer acks and probably to go through the ASoC
tree).

Plus the new dts changes with the graph need review (where as the
existing ones have been sent out 5 or so times w/o comment) before
they are merged.  Its just a ton of extra friction that doesn't gain
much and just keeps functionality from working upstream.

As for your concern about follow up, I've got the patches lined up here:
  https://git.linaro.org/people/john.stultz/android-dev.git/commit/?h=dev/hikey-mainline-WIP&id=31e8b980d93087cf30cd708fb0b2cc48e906d003

  https://git.linaro.org/people/john.stultz/android-dev.git/commit/?h=dev/hikey-mainline-WIP&id=f24a0ccdeeb46ce3eb8864fd43f7a34c673ff9da

And will revise and submit the adv7511 one for initial review today.

So again, I'm happy to migrate over. But I just think, as the graph
stuff doesn't actually benefit us much in this specific case (there is
only one supported audio out path right now), its not worth blocking
getting the functionality working upstream for another 3-6 months.

thanks
-john

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RESEND x3][PATCH v4] arm64: dts: hi6220: Add k3-dma and i2s/hdmi audio support John Stultz <john.stultz@linaro.org> - 2017-06-12 23:00 +0200
  Re: [RESEND x3][PATCH v4] arm64: dts: hi6220: Add k3-dma and  i2s/hdmi audio support Mark Brown <broonie@kernel.org> - 2017-06-13 00:20 +0200
    Re: [RESEND x3][PATCH v4] arm64: dts: hi6220: Add k3-dma and i2s/hdmi  audio support John Stultz <john.stultz@linaro.org> - 2017-06-13 02:50 +0200
      Re: [RESEND x3][PATCH v4] arm64: dts: hi6220: Add k3-dma and i2s/hdmi  audio support John Stultz <john.stultz@linaro.org> - 2017-06-13 21:50 +0200
        Re: [RESEND x3][PATCH v4] arm64: dts: hi6220: Add k3-dma and  i2s/hdmi audio support Mark Brown <broonie@kernel.org> - 2017-06-13 22:00 +0200
          Re: [RESEND x3][PATCH v4] arm64: dts: hi6220: Add k3-dma and i2s/hdmi  audio support John Stultz <john.stultz@linaro.org> - 2017-06-13 22:00 +0200
            Re: [RESEND x3][PATCH v4] arm64: dts: hi6220: Add k3-dma and  i2s/hdmi audio support Mark Brown <broonie@kernel.org> - 2017-06-13 22:20 +0200
              Re: [RESEND x3][PATCH v4] arm64: dts: hi6220: Add k3-dma and i2s/hdmi  audio support John Stultz <john.stultz@linaro.org> - 2017-06-13 22:50 +0200
                Re: [RESEND x3][PATCH v4] arm64: dts: hi6220: Add k3-dma and  i2s/hdmi audio support Mark Brown <broonie@kernel.org> - 2017-06-13 23:50 +0200
                Re: [RESEND x3][PATCH v4] arm64: dts: hi6220: Add k3-dma and i2s/hdmi  audio support John Stultz <john.stultz@linaro.org> - 2017-06-14 00:10 +0200
                Re: [RESEND x3][PATCH v4] arm64: dts: hi6220: Add k3-dma and  i2s/hdmi audio support Mark Brown <broonie@kernel.org> - 2017-06-14 16:50 +0200
                Re: [RESEND x3][PATCH v4] arm64: dts: hi6220: Add k3-dma and i2s/hdmi  audio support John Stultz <john.stultz@linaro.org> - 2017-06-14 20:10 +0200

csiph-web