Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1663599
| From | Krzysztof Kozlowski <krzk@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2 4/8] PM / Domains: Fix unsafe iteration over modified list of device links |
| Date | 2017-06-12 17:20 +0200 |
| Message-ID | <tRzii-3K9-17@gated-at.bofh.it> (permalink) |
| References | <tRzih-3K9-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
pm_genpd_remove_subdomain() iterates over domain's master_links list and
removes matching element thus it has to use safe version of list
iteration.
Fixes: f721889ff65a ("PM / Domains: Support for generic I/O PM domains (v8)")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/base/power/domain.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index 9d3d3c2a5979..d1e438024e46 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -1400,7 +1400,7 @@ EXPORT_SYMBOL_GPL(pm_genpd_add_subdomain);
int pm_genpd_remove_subdomain(struct generic_pm_domain *genpd,
struct generic_pm_domain *subdomain)
{
- struct gpd_link *link;
+ struct gpd_link *l, *link;
int ret = -EINVAL;
if (IS_ERR_OR_NULL(genpd) || IS_ERR_OR_NULL(subdomain))
@@ -1416,7 +1416,7 @@ int pm_genpd_remove_subdomain(struct generic_pm_domain *genpd,
goto out;
}
- list_for_each_entry(link, &genpd->master_links, master_node) {
+ list_for_each_entry_safe(link, l, &genpd->master_links, master_node) {
if (link->slave != subdomain)
continue;
--
2.9.3
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/8] PM / Domains: Bunch of small improvements and fixes Krzysztof Kozlowski <krzk@kernel.org> - 2017-06-12 17:20 +0200
[PATCH v2 4/8] PM / Domains: Fix unsafe iteration over modified list of device links Krzysztof Kozlowski <krzk@kernel.org> - 2017-06-12 17:20 +0200
Re: [PATCH v2 4/8] PM / Domains: Fix unsafe iteration over modified list of device links Ulf Hansson <ulf.hansson@linaro.org> - 2017-06-13 12:40 +0200
[PATCH v2 6/8] PM / Domains: Fix unsafe iteration over modified list of domains Krzysztof Kozlowski <krzk@kernel.org> - 2017-06-12 17:20 +0200
Re: [PATCH v2 6/8] PM / Domains: Fix unsafe iteration over modified list of domains Ulf Hansson <ulf.hansson@linaro.org> - 2017-06-13 12:40 +0200
csiph-web