Re: [PATCH v5 1/6] asm-generic/bug.h: declare struct pt_regs; before function prototype

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 1/6] asm-generic/bug.h: declare struct pt_regs; before function prototype
Date	2017-06-12 16:20 +0200
Message-ID	<tRyme-3aL-11@gated-at.bofh.it> (permalink)
References	<tKZKx-81K-3@gated-at.bofh.it> <tKZKx-81K-9@gated-at.bofh.it> <tQ6in-5iV-39@gated-at.bofh.it> <tRyme-3aL-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 12 Jun 2017 15:13:54 +0100
Ian Abbott <abbotti@mev.co.uk> wrote:

> >> diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
> >> index d6f4aed479a1..87191357d303 100644
> >> --- a/include/asm-generic/bug.h
> >> +++ b/include/asm-generic/bug.h
> >> @@ -97,6 +97,7 @@ extern void warn_slowpath_null(const char *file, const int line);
> >>
> >>  /* used internally by panic.c */
> >>  struct warn_args;
> >> +struct pt_regs;  
> >
> > Probably be better to move pt_regs above the comment. For one, it is
> > used before warn_args in the function below. Two, it's not defined
> > internally by panic.c like warn_args is.  
> 
> Alternatively, the comment could be placed on the same line as `struct 
> warn_args;`.  I don't think it's a big enough of a deal to patch it for 
> the sake of it, tbh.

trivial clean up patches are fine to add for merge windows.

Could just write a patch and send it to the trivial maintainer.

-- Steve

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 1/6] asm-generic/bug.h: declare struct pt_regs;  before function prototype Steven Rostedt <rostedt@goodmis.org> - 2017-06-08 16:10 +0200
  Re: [PATCH v5 1/6] asm-generic/bug.h: declare struct pt_regs; before  function prototype Ian Abbott <abbotti@mev.co.uk> - 2017-06-12 16:20 +0200
    Re: [PATCH v5 1/6] asm-generic/bug.h: declare struct pt_regs;  before function prototype Steven Rostedt <rostedt@goodmis.org> - 2017-06-12 16:20 +0200

csiph-web