Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1663525
| From | Dave Hansen <dave.hansen@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v11 6/6] virtio-balloon: VIRTIO_BALLOON_F_CMD_VQ |
| Date | 2017-06-12 16:10 +0200 |
| Message-ID | <tRycy-37z-9@gated-at.bofh.it> (permalink) |
| References | <tQpEl-qv-1@gated-at.bofh.it> <tQpEm-qv-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 06/09/2017 03:41 AM, Wei Wang wrote:
> + for_each_populated_zone(zone) {
> + for (order = MAX_ORDER - 1; order > 0; order--) {
> + for (migratetype = 0; migratetype < MIGRATE_TYPES;
> + migratetype++) {
> + do {
> + ret = report_unused_page_block(zone,
> + order, migratetype, &page);
> + if (!ret) {
> + pfn = (u64)page_to_pfn(page);
> + add_one_chunk(vb, vq,
> + PAGE_CHNUK_UNUSED_PAGE,
> + pfn << VIRTIO_BALLOON_PFN_SHIFT,
> + (u64)(1 << order) *
> + VIRTIO_BALLOON_PAGES_PER_PAGE);
> + }
> + } while (!ret);
> + }
> + }
> + }
This is pretty unreadable. Please add some indentation. If you go
over 80 cols, then you might need to break this up into a separate
function. But, either way, it can't be left like this.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v11 0/6] Virtio-balloon Enhancement Wei Wang <wei.w.wang@intel.com> - 2017-06-09 12:50 +0200
[PATCH v11 5/6] mm: export symbol of next_zone and first_online_pgdat Wei Wang <wei.w.wang@intel.com> - 2017-06-09 12:50 +0200
[PATCH v11 4/6] mm: function to offer a page block on the free list Wei Wang <wei.w.wang@intel.com> - 2017-06-09 12:50 +0200
Re: [PATCH v11 4/6] mm: function to offer a page block on the free list Dave Hansen <dave.hansen@intel.com> - 2017-06-12 16:20 +0200
Re: [PATCH v11 4/6] mm: function to offer a page block on the free list "Michael S. Tsirkin" <mst@redhat.com> - 2017-06-12 18:30 +0200
Re: [PATCH v11 4/6] mm: function to offer a page block on the free list Dave Hansen <dave.hansen@intel.com> - 2017-06-12 18:50 +0200
Re: [PATCH v11 4/6] mm: function to offer a page block on the free list "Michael S. Tsirkin" <mst@redhat.com> - 2017-06-12 22:40 +0200
Re: [PATCH v11 4/6] mm: function to offer a page block on the free list Dave Hansen <dave.hansen@intel.com> - 2017-06-12 23:00 +0200
Re: [PATCH v11 4/6] mm: function to offer a page block on the free list Wei Wang <wei.w.wang@intel.com> - 2017-06-13 05:00 +0200
[PATCH v11 1/6] virtio-balloon: deflate via a page list Wei Wang <wei.w.wang@intel.com> - 2017-06-09 12:50 +0200
[PATCH v11 2/6] virtio-balloon: coding format cleanup Wei Wang <wei.w.wang@intel.com> - 2017-06-09 12:50 +0200
[PATCH v11 6/6] virtio-balloon: VIRTIO_BALLOON_F_CMD_VQ Wei Wang <wei.w.wang@intel.com> - 2017-06-09 12:50 +0200
Re: [PATCH v11 6/6] virtio-balloon: VIRTIO_BALLOON_F_CMD_VQ Dave Hansen <dave.hansen@intel.com> - 2017-06-12 16:10 +0200
Re: [PATCH v11 6/6] virtio-balloon: VIRTIO_BALLOON_F_CMD_VQ Wei Wang <wei.w.wang@intel.com> - 2017-06-13 12:20 +0200
[PATCH v11 3/6] virtio-balloon: VIRTIO_BALLOON_F_PAGE_CHUNKS Wei Wang <wei.w.wang@intel.com> - 2017-06-09 13:00 +0200
Re: [PATCH v11 3/6] virtio-balloon: VIRTIO_BALLOON_F_PAGE_CHUNKS "Michael S. Tsirkin" <mst@redhat.com> - 2017-06-13 20:00 +0200
Re: [PATCH v11 3/6] virtio-balloon: VIRTIO_BALLOON_F_PAGE_CHUNKS Dave Hansen <dave.hansen@intel.com> - 2017-06-13 20:00 +0200
Re: [PATCH v11 3/6] virtio-balloon: VIRTIO_BALLOON_F_PAGE_CHUNKS "Michael S. Tsirkin" <mst@redhat.com> - 2017-06-13 21:00 +0200
Re: [virtio-dev] Re: [PATCH v11 3/6] virtio-balloon: VIRTIO_BALLOON_F_PAGE_CHUNKS Wei Wang <wei.w.wang@intel.com> - 2017-06-15 10:10 +0200
Re: [virtio-dev] Re: [PATCH v11 3/6] virtio-balloon: VIRTIO_BALLOON_F_PAGE_CHUNKS "Michael S. Tsirkin" <mst@redhat.com> - 2017-06-16 05:20 +0200
RE: [PATCH v11 0/6] Virtio-balloon Enhancement "Wang, Wei W" <wei.w.wang@intel.com> - 2017-06-09 13:20 +0200
csiph-web