Re: [PATCH] usb: host: ehci-exynos: Handle return value of clk_prepare_enable

From	Alan Stern <stern@rowland.harvard.edu>
Newsgroups	linux.kernel
Subject	Re: [PATCH] usb: host: ehci-exynos: Handle return value of clk_prepare_enable
Date	2017-06-12 16:10 +0200
Message-ID	<tRycy-37z-5@gated-at.bofh.it> (permalink)
References	<tRvy2-1qM-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 12 Jun 2017, Arvind Yadav wrote:

> clk_prepare_enable() can fail here and we must check its return value.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/usb/host/ehci-exynos.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c
> index 7a603f6..26b6411 100644
> --- a/drivers/usb/host/ehci-exynos.c
> +++ b/drivers/usb/host/ehci-exynos.c
> @@ -279,7 +279,9 @@ static int exynos_ehci_resume(struct device *dev)
>  	struct exynos_ehci_hcd *exynos_ehci = to_exynos_ehci(hcd);
>  	int ret;
>  
> -	clk_prepare_enable(exynos_ehci->clk);
> +	ret = clk_prepare_enable(exynos_ehci->clk);
> +	if (ret)
> +		return ret;
>  
>  	ret = exynos_ehci_phy_enable(dev);
>  	if (ret) {

Acked-by: Alan Stern <stern@rowland.harvard.edu>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] usb: host: ehci-exynos: Handle return value of clk_prepare_enable Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-12 13:20 +0200
  Re: [PATCH] usb: host: ehci-exynos: Handle return value of  clk_prepare_enable Krzysztof Kozlowski <krzk@kernel.org> - 2017-06-12 14:10 +0200
  Re: [PATCH] usb: host: ehci-exynos: Handle return value of  clk_prepare_enable Alan Stern <stern@rowland.harvard.edu> - 2017-06-12 16:10 +0200

csiph-web