Re: [PATCH v2] nvme: use uuid_t in nvme_ns

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] nvme: use uuid_t in nvme_ns
Date	2017-06-12 15:20 +0200
Message-ID	<tRxqa-2AI-19@gated-at.bofh.it> (permalink)
References	<tRtFV-fr-35@gated-at.bofh.it> <tRuiB-sU-9@gated-at.bofh.it> <tRush-NN-1@gated-at.bofh.it> <tRvom-1nx-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jun 12, 2017 at 2:03 PM, Christoph Hellwig <hch@lst.de> wrote:
> On Mon, Jun 12, 2017 at 12:04:18PM +0200, Johannes Thumshirn wrote:
>> > So, this reveals two thins:
>> > 1) shall we define NVME_NIDT_UUID_LEN to be UUID_LEN or substitute it
>> > completely with the latter?
>>
>> No, we have NVME_NIDT_UUID_LEN but also NVME_NIDT_NGUID_LEN and
>> NVME_NIDT_EUI64_LEN.
>
> Yeah, and I'd rather keep the defines for fields defined in the spec
> in nvme.h
>
>> I'm not sure the NVMe NGUID is the same as a GUID (a.k.a little endian
>> UUID). Quoting from the spec:
>
> It's not at all, the field just has a very unfortunate name in the
> spec.

Thanks for explanations.

So, wrt that
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

-- 
With Best Regards,
Andy Shevchenko

Thread

[PATCH v2] nvme: use uuid_t in nvme_ns Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-12 11:20 +0200
  Re: [PATCH v2] nvme: use uuid_t in nvme_ns Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-12 12:00 +0200
    Re: [PATCH v2] nvme: use uuid_t in nvme_ns Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-12 12:10 +0200
      Re: [PATCH v2] nvme: use uuid_t in nvme_ns Christoph Hellwig <hch@lst.de> - 2017-06-12 13:10 +0200
        Re: [PATCH v2] nvme: use uuid_t in nvme_ns Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-12 15:20 +0200
  Re: [PATCH v2] nvme: use uuid_t in nvme_ns Christoph Hellwig <hch@lst.de> - 2017-06-12 18:10 +0200
  Re: [PATCH v2] nvme: use uuid_t in nvme_ns Sagi Grimberg <sagi@grimberg.me> - 2017-06-15 11:00 +0200

csiph-web