Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Kai-Heng Feng <kai.heng.feng@canonical.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller
Date	Mon, 12 Jun 2017 12:20:02 +0200
Message-ID	<tRuBY-R6-3@gated-at.bofh.it> (permalink)
References	<tQmwO-72q-11@gated-at.bofh.it> <tQtoB-2MZ-5@gated-at.bofh.it> <tRrE5-7tD-1@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=fBm3/80iGL0asL65+wtwQu/ICCSHdLTU7/Tk7YxKvdc=; b=Sw6TxdvCHdSo0BwwlCbbntlzTyf+d6O/yZc4IW+bHC+muiA+JB8Ph5ZLKU5kuYtsjO 5h7K8A/n4MgiOUd8p4csjZctunB5GPdh2L/W8Fxcjxfy50E3DoPk/eaMMUFPxIBGmS75 u2ZpCDgfCkwD4ZU7+5Wid/6szBOhxGg0WZ1mubta4oh0C7VPUw/FhPCmE7kM+DynL63N /cYbdIlWa9nPMRvRl6ctR4EsEwvyWqtlQ/cX6ABCSQmndZkaz+NiTsE5iuIyAXkzWLIt CbAUb6jKWlvLi4TmYnOZAitoTZ/heK5XVilaI/e9BZc2RgLIJr7qbQMg4/dCr7TZfiFW RTQA==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=fBm3/80iGL0asL65+wtwQu/ICCSHdLTU7/Tk7YxKvdc=; b=DXmm5xBcjHwm+rx8HenhqLQlhSeCJWrtbMUZjLF4SDPFfxiGuW7jeXRBPYsDnzaojm ROsM/r3eOQwgd4fHn+LsoUbibFWiaChcADZzuPTuyfJFdkCxANqy1NrCTdIaCghf53Zk JG9ucy24cv+6/z/UuH4e1azoq0B0fDMVdBKqJaz0eHReaFDpWoDI4C90mUbhQ3reeeDX LG4Rd9Fd3q9VtyPk5i9xqBaL8CuC6w4KZtgjJkGaD0zL1ixlsuOTCXfiB4jqHrQxynjo a9qIrWR17z9AF8eyDm5VbCcdf+Iw3fKxKbQ9Bnr/tLo0Nolu/8awKuZHGmOlokJFAIc7 oSNA==
X-Gm-Message-State	AODbwcDs9gV8jVE13WDX2wb4hKTLm/Bx9zHRF9oruHC3TPiWGKmYvhYJ pqdOI3Bkz2FqnhWAKGX0OX8jASWPI8HE
X-Received	by 10.223.147.165 with SMTP id 34mr6239469wrp.175.1497262363072; Mon, 12 Jun 2017 03:12:43 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset="UTF-8"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	36
Organization	linux.* mail to news gateway
X-Original-Cc	gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
X-Original-Date	Mon, 12 Jun 2017 18:12:42 +0800
X-Original-Message-ID	<CAAd53p6S9NPBD=qGP419mhBgSgn-s1dc=adued8Y+Y0=GDsHKg@mail.gmail.com>
X-Original-References	<20170609072233.5594-1-kai.heng.feng@canonical.com> <Pine.LNX.4.44L0.1706091036070.2100-100000@iolanthe.rowland.org> <CAAd53p7OS+FYjLGts+R=H6qr0=b21Xu_uDn=y0eeAxowpfnj0A@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1663398

Show key headers only | View raw

On Mon, Jun 12, 2017 at 3:04 PM, Kai-Heng Feng
<kai.heng.feng@canonical.com> wrote:
> On Fri, Jun 9, 2017 at 10:43 PM, Alan Stern <stern@rowland.harvard.edu> wrote:
>> On Fri, 9 Jun 2017, Kai-Heng Feng wrote:
>>
>> Is this really the right solution?  Maybe it would be better to allow
>> the controller to go into D3 provided no wakeup signal is needed.  You
>> could do:
>>
>>                 device_set_wakeup_capable(&pdev->dev, 0);
>
> This doesn't work.
> After applying this function, still nothing happens when devices get plugged in.
> IIUC this function disable the wakeup function, but what I want to do
> here is to have PME signal works even when runtime PM is enabled.
>
> I also saw some legacy PCI PM stuff, so I also tried:
> device_set_wakeup_capable(&pdev->dev, 1);
> ...doesn't work either.
>
>>
>> Another alternative is to put the controller into D2 instead of D3, but
>> (1) I don't know how to do that, and (2) we don't know if wakeup
>> signalling works any better in D2 than it does in D3.
>
> I'll try if D2 works.

Put the device into D2 instead of D3 can make the wakeup signaling
work, i.e. USB devices can be correctly detected after plugged into
EHCI port.

Do you think this alternative an acceptable workaround?

>
> Thanks for the review.
>

Thread

[PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller Kai-Heng Feng <kai.heng.feng@canonical.com> - 2017-06-09 09:30 +0200
  Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller Alan Stern <stern@rowland.harvard.edu> - 2017-06-09 16:50 +0200
    Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller Kai-Heng Feng <kai.heng.feng@canonical.com> - 2017-06-12 09:10 +0200
      Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller Kai-Heng Feng <kai.heng.feng@canonical.com> - 2017-06-12 12:20 +0200
        Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller Alan Stern <stern@rowland.harvard.edu> - 2017-06-12 16:20 +0200
          Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller Kai-Heng Feng <kai.heng.feng@canonical.com> - 2017-06-13 06:30 +0200
            Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI  controller Bjorn Helgaas <helgaas@kernel.org> - 2017-06-13 19:30 +0200
              Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller Alan Stern <stern@rowland.harvard.edu> - 2017-06-14 21:00 +0200
                Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller Kai-Heng Feng <kai.heng.feng@canonical.com> - 2017-06-15 09:10 +0200
                Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI  controller Bjorn Helgaas <helgaas@kernel.org> - 2017-06-15 15:30 +0200
              Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller Kai-Heng Feng <kai.heng.feng@canonical.com> - 2017-06-15 09:00 +0200
                Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller Alan Stern <stern@rowland.harvard.edu> - 2017-06-15 16:20 +0200
                Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller Kai-Heng Feng <kai.heng.feng@canonical.com> - 2017-06-16 05:10 +0200
                Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller Kai-Heng Feng <kai.heng.feng@canonical.com> - 2017-06-16 18:20 +0200
                Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller Alan Stern <stern@rowland.harvard.edu> - 2017-06-16 19:40 +0200
                Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller Kai-Heng Feng <kai.heng.feng@canonical.com> - 2017-06-19 05:40 +0200
                Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI  controller Bjorn Helgaas <helgaas@kernel.org> - 2017-06-19 19:50 +0200
                Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller Alan Stern <stern@rowland.harvard.edu> - 2017-06-19 20:40 +0200
                Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-06-20 00:10 +0200

csiph-web