Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1663378

Re: [PATCH v3 1/3] mfd: Add new mfd device TPS68470

From Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v3 1/3] mfd: Add new mfd device TPS68470
Date 2017-06-12 11:50 +0200
Message-ID <tRu8W-p0-15@gated-at.bofh.it> (permalink)
References <tRtZf-lF-3@gated-at.bofh.it> <tRtZg-lF-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Jun 12, 2017 at 12:26 PM, Rajmohan Mani <rajmohan.mani@intel.com> wrote:
> The TPS68470 device is an advanced power management
> unit that powers a Compact Camera Module (CCM),
> generates clocks for image sensors, drives a dual
> LED for Flash and incorporates two LED drivers for
> general purpose indicators.
>
> This patch adds support for TPS68470 mfd device.

> +#include <linux/i2c.h>

If you are going to ignore reviewers' comments you may delay the patch
upstreaming for quite a bit.

P.S. For now I don't see any priority to review v3.
I noted more issues that weren't addressed.

Sorry.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v3 0/3] TPS68470 PMIC drivers  Rajmohan Mani <rajmohan.mani@intel.com> - 2017-06-12 11:40 +0200
  [PATCH v3 2/3] gpio: Add support for TPS68470 GPIOs Rajmohan Mani <rajmohan.mani@intel.com> - 2017-06-12 11:40 +0200
  [PATCH v3 1/3] mfd: Add new mfd device TPS68470 Rajmohan Mani <rajmohan.mani@intel.com> - 2017-06-12 11:40 +0200
    Re: [PATCH v3 1/3] mfd: Add new mfd device TPS68470 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-12 11:50 +0200
      RE: [PATCH v3 1/3] mfd: Add new mfd device TPS68470 "Mani, Rajmohan" <rajmohan.mani@intel.com> - 2017-06-12 12:10 +0200

csiph-web