Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1663356

[char-misc-next 2/3] mei: drop unreachable code in mei_start

Show all headers | View raw

From: Alexander Usyskin <alexander.usyskin@intel.com>

Device disabled state is caught inside the retry loop, so
there is no need to check it once again afterwards.

Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
 drivers/misc/mei/init.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/misc/mei/init.c b/drivers/misc/mei/init.c
index c8ad9ee7cb80..d2f691424dd1 100644
--- a/drivers/misc/mei/init.c
+++ b/drivers/misc/mei/init.c
@@ -215,12 +215,6 @@ int mei_start(struct mei_device *dev)
 		}
 	} while (ret);
 
-	/* we cannot start the device w/o hbm start message completed */
-	if (dev->dev_state == MEI_DEV_DISABLED) {
-		dev_err(dev->dev, "reset failed");
-		goto err;
-	}
-
 	if (mei_hbm_start_wait(dev)) {
 		dev_err(dev->dev, "HBM haven't started");
 		goto err;
-- 
2.9.4

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[char-misc-next 1/3] mei: validate the message header only in first fragment. Tomas Winkler <tomas.winkler@intel.com> - 2017-06-12 11:20 +0200
  [char-misc-next 2/3] mei: drop unreachable code in mei_start Tomas Winkler <tomas.winkler@intel.com> - 2017-06-12 11:20 +0200

csiph-web