Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1663352

Re: [PATCH v2 1/3] mfd: Add new mfd device TPS68470

From Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 1/3] mfd: Add new mfd device TPS68470
Date 2017-06-12 11:20 +0200
Message-ID <tRtFV-fr-29@gated-at.bofh.it> (permalink)
References <tR4o9-1x7-7@gated-at.bofh.it> <tR4oa-1x7-15@gated-at.bofh.it> <tRaWB-5w9-3@gated-at.bofh.it> <tRtFV-fr-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Jun 12, 2017 at 12:12 PM, Mani, Rajmohan
<rajmohan.mani@intel.com> wrote:

>> > +#include <linux/i2c.h>
>>
>> And this is for...?

> use by tps68470.c which uses i2c_driver and other such i2c defines.

It should be in C-file, not in the header which has nothing to do with I2C APIs.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 0/3] TPS68470 PMIC drivers  Rajmohan Mani <rajmohan.mani@intel.com> - 2017-06-11 08:20 +0200
  [PATCH v2 1/3] mfd: Add new mfd device TPS68470 Rajmohan Mani <rajmohan.mani@intel.com> - 2017-06-11 08:20 +0200
    Re: [PATCH v2 1/3] mfd: Add new mfd device TPS68470 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-11 15:20 +0200
      Re: [PATCH v2 1/3] mfd: Add new mfd device TPS68470 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-12 11:20 +0200
      RE: [PATCH v2 1/3] mfd: Add new mfd device TPS68470 "Mani, Rajmohan" <rajmohan.mani@intel.com> - 2017-06-12 11:20 +0200
  [PATCH v2 2/3] gpio: Add support for TPS68470 GPIOs Rajmohan Mani <rajmohan.mani@intel.com> - 2017-06-11 08:20 +0200
    Re: [PATCH v2 2/3] gpio: Add support for TPS68470 GPIOs Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-11 16:00 +0200
      RE: [PATCH v2 2/3] gpio: Add support for TPS68470 GPIOs "Mani, Rajmohan" <rajmohan.mani@intel.com> - 2017-06-12 11:20 +0200

csiph-web