Re: [PATCH 1/3] ARM: dts: omap4: add missing des_fck

From	Tero Kristo <t-kristo@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] ARM: dts: omap4: add missing des_fck
Date	2017-06-12 10:20 +0200
Message-ID	<tRsJP-86G-7@gated-at.bofh.it> (permalink)
References	<tQBm9-7M4-3@gated-at.bofh.it> <tQBma-7M4-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10/06/17 02:12, Sebastian Reichel wrote:
> Add missing functional clock for DES3DES IP core. This is
> documented in the TRM as CM_L4SEC_DES3DES_CLKCTRL.
> 
> Signed-off-by: Sebastian Reichel <sre@kernel.org>
> ---
>   arch/arm/boot/dts/omap44xx-clocks.dtsi | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/omap44xx-clocks.dtsi b/arch/arm/boot/dts/omap44xx-clocks.dtsi
> index 9573b37fbaa7..e997265460d4 100644
> --- a/arch/arm/boot/dts/omap44xx-clocks.dtsi
> +++ b/arch/arm/boot/dts/omap44xx-clocks.dtsi
> @@ -985,6 +985,14 @@
>   		reg = <0x15a8>;
>   	};
>   
> +	des_fck: des_fck@15b0 {
> +		#clock-cells = <0>;
> +		compatible = "ti,gate-clock";
> +		clocks = <&l3_div_ck>;
> +		ti,bit-shift = <1>;
> +		reg = <0x15b0>;
> +	};
> +
>   	dss_sys_clk: dss_sys_clk@1120 {
>   		#clock-cells = <0>;
>   		compatible = "ti,gate-clock";
> 

NAK. Don't add a duplicate entry for the hwmod clkctrl clock. You are 
adding control to the exact same bit via the hwmod data entry also 
causing a possibility for race condition.

-Tero

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] OMAP4: crypto support Sebastian Reichel <sre@kernel.org> - 2017-06-10 01:20 +0200
  [PATCH 2/3] ARM: OMAP4: hwmod data: add aes Sebastian Reichel <sre@kernel.org> - 2017-06-10 01:20 +0200
    Re: [PATCH 2/3] ARM: OMAP4: hwmod data: add aes Tero Kristo <t-kristo@ti.com> - 2017-06-12 10:30 +0200
  [PATCH 3/3] ARM: OMAP4: hwmod data: add des Sebastian Reichel <sre@kernel.org> - 2017-06-10 01:20 +0200
    Re: [PATCH 3/3] ARM: OMAP4: hwmod data: add des Tero Kristo <t-kristo@ti.com> - 2017-06-12 10:20 +0200
  [PATCH 1/3] ARM: dts: omap4: add missing des_fck Sebastian Reichel <sre@kernel.org> - 2017-06-10 01:20 +0200
    Re: [PATCH 1/3] ARM: dts: omap4: add missing des_fck Tony Lindgren <tony@atomide.com> - 2017-06-12 09:30 +0200
    Re: [PATCH 1/3] ARM: dts: omap4: add missing des_fck Tero Kristo <t-kristo@ti.com> - 2017-06-12 10:20 +0200

csiph-web