Re: [PATCH 1/3] mm: add vm_insert_mixed_mkwrite()

From	Ross Zwisler <ross.zwisler@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] mm: add vm_insert_mixed_mkwrite()
Date	2017-06-12 06:10 +0200
Message-ID	<tRoPT-5Gb-1@gated-at.bofh.it> (permalink)
References	<tPQ3U-34T-31@gated-at.bofh.it> <tQzDH-6HJ-11@gated-at.bofh.it> <tQEWL-1FJ-15@gated-at.bofh.it> <tQFpL-1Pk-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jun 09, 2017 at 08:35:08PM -0700, Dan Williams wrote:
> On Fri, Jun 9, 2017 at 8:03 PM, Ross Zwisler
> <ross.zwisler@linux.intel.com> wrote:
> > And vm_insert_mixed_mkwrite() and vm_insert_mixed() are redundant with only
> > the insert_pfn() line differing?  This doesn't seem better...unless I'm
> > missing something?
> >
> > The way it is, vm_insert_mixed_mkwrite() also closely matches
> > insert_pfn_pmd(), which we use in the PMD case and which also takes a 'write'
> > boolean which works the same as our newly added 'mkwrite'.
> 
> Hmm, but now the pfn and pmd cases are inconsistent, if you put the
> flag name in the function then don't add an argument, or make it like
> the pmd case and add an argument to vm_insert_mixed(). I prefer the
> former.

Okay, I'll fix this for v2.  Thanks for the review.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] mm: add vm_insert_mixed_mkwrite() Ross Zwisler <ross.zwisler@linux.intel.com> - 2017-06-07 23:00 +0200
  [PATCH 2/3] dax: relocate dax_load_hole() Ross Zwisler <ross.zwisler@linux.intel.com> - 2017-06-07 23:00 +0200
  Re: [PATCH 1/3] mm: add vm_insert_mixed_mkwrite() Dan Williams <dan.j.williams@intel.com> - 2017-06-09 23:30 +0200
    Re: [PATCH 1/3] mm: add vm_insert_mixed_mkwrite() Ross Zwisler <ross.zwisler@linux.intel.com> - 2017-06-10 05:10 +0200
      Re: [PATCH 1/3] mm: add vm_insert_mixed_mkwrite() Dan Williams <dan.j.williams@intel.com> - 2017-06-10 05:40 +0200
        Re: [PATCH 1/3] mm: add vm_insert_mixed_mkwrite() Ross Zwisler <ross.zwisler@linux.intel.com> - 2017-06-12 06:10 +0200

csiph-web