Re: [RFC PATCH 1/4] EDAC: mvebu: Add driver for Marvell Armada SoCs

From	Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 1/4] EDAC: mvebu: Add driver for Marvell Armada SoCs
Date	2017-06-12 00:40 +0200
Message-ID	<tRjGx-2jJ-1@gated-at.bofh.it> (permalink)
References	<tPX5n-7J4-3@gated-at.bofh.it> <tPX5o-7J4-11@gated-at.bofh.it> <tQrZw-1Zf-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10/06/17 01:19, Jan Lübbe wrote:
>> +
>> +	if (edac_op_state == EDAC_OPSTATE_INT) {
>> +		/* acquire interrupt that reports errors */
>> +		pdata->irq = platform_get_irq(pdev, 0);
>> +		res = devm_request_irq(&pdev->dev,
>> +				       pdata->irq,
>> +				       mvebu_mc_isr,
>> +				       0,
>> +				       "[EDAC] MC err",
>> +				       mci);
> Which IRQ do you use? The current DT doesn't configure interrupts. Also
> it seems that the events are passed through additional layers of
> mask/status registers which are not yet represented in the Armada-XP IRQ
> hierarchy. So my driver currently uses polling.

Yes I'd been forcing polling too. To get this working properly I think 
we'd need to add another irqchip driver for the SoC Err interrupts. 
Which is kind of where I'd got stuck, the datasheet is a little 
confusing in that area. I think I'd figured out that the root interrupt 
comes through INT 4 which could be cascaded to the as yet unwritten SoC 
Err irqchip.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH 1/4] EDAC: mvebu: Add driver for Marvell Armada SoCs Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-08 06:20 +0200
  Re: [RFC PATCH 1/4] EDAC: mvebu: Add driver for Marvell Armada SoCs Borislav Petkov <bp@alien8.de> - 2017-06-09 12:40 +0200
  Re: [RFC PATCH 1/4] EDAC: mvebu: Add driver for Marvell Armada SoCs Jan Lübbe <jlu@pengutronix.de> - 2017-06-09 15:20 +0200
    DMA-safety for edac_atomic_scrub on ARM Jan Lübbe <jlu@pengutronix.de> - 2017-06-09 16:00 +0200
      Re: DMA-safety for edac_atomic_scrub on ARM Rob Herring <robh@kernel.org> - 2017-06-09 18:20 +0200
    Re: [RFC PATCH 1/4] EDAC: mvebu: Add driver for Marvell Armada SoCs Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-06-12 00:40 +0200

csiph-web