Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1664854

[PATCH] Add printk for bonding module packets_per_slave parameter

Show all headers | View raw

The packets per slave parameter used by round robin mode does not have a printk debug
message in its set function in bond_options.c. Adding such a function would aid debugging
of round-robin mode and allow the user to more easily verify that the parameter has been
set correctly. I should add that I'm motivated by my own experience here - it's not
obvious from output of tools such as wireshark and ifstat that the parameter is working
correctly, and with the differences in bonding configuration across different distributions,
it would have been comforting to see this output.

Signed-off-by: Michael Dilmore <michael.j.dilmore@gmail.com>

cc: Veaceslav Falico <vfalico@gmail.com>,Andy Gospodarek <andy@greyhouse.net>,netdev@vger.kernel.org,linux-kernel@vger.kernel.org
---
 drivers/net/bonding/bond_options.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c
index 1bcbb8913e17..4da0de1bab0a 100644
--- a/drivers/net/bonding/bond_options.c
+++ b/drivers/net/bonding/bond_options.c
@@ -1233,6 +1233,8 @@ static int bond_option_lp_interval_set(struct bonding *bond,
 static int bond_option_pps_set(struct bonding *bond,
 			       const struct bond_opt_value *newval)
 {
+	netdev_info(bond->dev, "Setting packets per slave to %d\n",
+		    newval->value);
 	bond->params.packets_per_slave = newval->value;
 	if (newval->value > 0) {
 		bond->params.reciprocal_packets_per_slave =
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] Add printk for bonding module packets_per_slave parameter Michael Dilmore <michael.j.dilmore@gmail.com> - 2017-06-13 15:50 +0200
  Re: [PATCH] Add printk for bonding module packets_per_slave  parameter David Miller <davem@davemloft.net> - 2017-06-13 17:40 +0200
    Re: [PATCH] Add printk for bonding module packets_per_slave  parameter Joe Perches <joe@perches.com> - 2017-06-13 18:30 +0200
      Re: [PATCH] Add printk for bonding module packets_per_slave parameter Jonathan Toppins <jtoppins@redhat.com> - 2017-06-13 18:50 +0200
        Re: [PATCH] Add printk for bonding module packets_per_slave  parameter Joe Perches <joe@perches.com> - 2017-06-13 19:10 +0200
          Re: [PATCH] Add printk for bonding module packets_per_slave parameter Nikolay Aleksandrov <nikolay@cumulusnetworks.com> - 2017-06-13 20:00 +0200
      Re: [PATCH] Add printk for bonding module packets_per_slave  parameter David Miller <davem@davemloft.net> - 2017-06-13 18:50 +0200
  Re: [PATCH] Add printk for bonding module packets_per_slave parameter kbuild test robot <lkp@intel.com> - 2017-06-14 01:20 +0200

csiph-web