Re: [PATCH 20/22] scsi: hisi_sas: Add v3 code to support ECC and AXI bus fatal error

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	John Garry <john.garry@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 20/22] scsi: hisi_sas: Add v3 code to support ECC and AXI bus fatal error
Date	Tue, 13 Jun 2017 16:10:02 +0200
Message-ID	<tRUG6-w3-29@gated-at.bofh.it> (permalink)
References	<tI4dH-1LO-3@gated-at.bofh.it> <tI4np-1Pa-45@gated-at.bofh.it> <tI6fw-32g-5@gated-at.bofh.it> <tI6pb-35o-9@gated-at.bofh.it>
User-Agent	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0
MIME-Version	1.0
Content-Type	text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding	7bit
X-Originating-IP	[10.203.181.153]
X-Cfilter-Loop	Reflected
X-Mirapoint-Virus-Rapid-Raw	score=unknown(0), refid=str=0001.0A020201.593FF138.026C,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-ID	49cf5ff1da65f1133661263e21b4dc90
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	57
Organization	linux.* mail to news gateway
X-Original-Cc	"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, John Garry <john.garry2@mail.dcu.ie>, <linuxarm@huawei.com>, <linux-scsi@vger.kernel.org>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, Xiang Chen <chenxiang66@hisilicon.com>
X-Original-Date	Tue, 13 Jun 2017 15:05:30 +0100
X-Original-Message-ID	<cc74b7c2-4946-af6a-b761-cdfba2162a4d@huawei.com>
X-Original-References	<1495018197-120535-1-git-send-email-john.garry@huawei.com> <1495018197-120535-21-git-send-email-john.garry@huawei.com> <CAK8P3a3jh8QqcHgdAkpA9SADZ0RfD2i63A-RHkN9+gJ31sL74g@mail.gmail.com> <438a97a7-b424-a599-0c65-1e79dcdf8e86@huawei.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1664903

Show key headers only | View raw

On 17/05/2017 13:38, John Garry wrote:
> On 17/05/2017 13:27, Arnd Bergmann wrote:
>> On Wed, May 17, 2017 at 12:49 PM, John Garry <john.garry@huawei.com>
>> wrote:
>>> > From: Xiang Chen <chenxiang66@hisilicon.com>
>>> >
>>> > For ECC 1bit error, logic can recover it, so we only print a warning.
>>> > For ECC multi-bit and AXI bus fatal error, we panic.
>>> >
>>> > Signed-off-by: John Garry <john.garry@huawei.com>
>>> > Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
>> This one is tricky as there are conflicting requirements:
>>
>> - For debugging purposes, you want to continue running the system
>>   to figure out what exactly went wrong. Often enough, having the
>>   kernel panic means you don't get to see the panic message because
>>   console access is unavailable and you cannot log in any more
>>
>> - For data consistency purposes you want to stop the system as
>>   soon as there is any uncorrectable data error
>>
>> I see that most scsi drivers don't ever call panic or BUG(), though
>> you already do so for v1 and v2 hw.
>>
>> Maybe the SCSI maintainers can provide some more guidance here.
>>
>>       Arnd
>>
>> .
>>
>
> Hi Arnd,
>
> Actually latest code for v2 has been updated to do a controller reset,
> and not panic, for unrecoverable error:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c?h=v4.12-rc1#n2926
>
>
> We never got around to implementing controller reset for v1 as this
> platform (hip05) is not used much anymore.
>
> As for v3, we will change to to do same once controller reset is
> implemented. I should have added this to the commit log.
>
> Thanks,
> John

It has come to light that hip08 RAS architecture requires handling 
certain errors with firmware first model. I am not sure on the flow of 
controller reset for fatal errors - I'm currently checking the details.

But it is not worth adding this non-critical patch and reverting it 
later, so I'll omit this patch when sending the v6 patchset which 
includes the fix for sloppy spinlock usage.

Thanks,
John

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 20/22] scsi: hisi_sas: Add v3 code to support ECC and AXI  bus fatal error John Garry <john.garry@huawei.com> - 2017-06-13 16:10 +0200

csiph-web