Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1664738

Re: [PATCH v2 5/8] PM / Domains: Fix unsafe iteration over modified list of domain providers

Show all headers | View raw

On 12 June 2017 at 17:17, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> of_genpd_del_provider() iterates over list of domain provides and
> removes matching element thus it has to use safe version of list
> iteration.
>
> Fixes: aa42240ab254 ("PM / Domains: Add generic OF-based PM domain look-up")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Acked-by: Ulf Hansson <ulf.hansson@linaro.org>

> ---
>  drivers/base/power/domain.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index d1e438024e46..b74b5111957a 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -1789,12 +1789,12 @@ EXPORT_SYMBOL_GPL(of_genpd_add_provider_onecell);
>   */
>  void of_genpd_del_provider(struct device_node *np)
>  {
> -       struct of_genpd_provider *cp;
> +       struct of_genpd_provider *cp, *tmp;
>         struct generic_pm_domain *gpd;
>
>         mutex_lock(&gpd_list_lock);
>         mutex_lock(&of_genpd_mutex);
> -       list_for_each_entry(cp, &of_genpd_providers, link) {
> +       list_for_each_entry_safe(cp, tmp, &of_genpd_providers, link) {
>                 if (cp->node == np) {
>                         /*
>                          * For each PM domain associated with the
> --
> 2.9.3
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 5/8] PM / Domains: Fix unsafe iteration over modified list of domain providers Krzysztof Kozlowski <krzk@kernel.org> - 2017-06-12 17:20 +0200
  Re: [PATCH v2 5/8] PM / Domains: Fix unsafe iteration over modified  list of domain providers Ulf Hansson <ulf.hansson@linaro.org> - 2017-06-13 12:40 +0200

csiph-web