Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1664642

Re: [PATCH] drm/exynos/dsi: Remove error handling for bridge_node DT parsing

From Inki Dae <inki.dae@samsung.com>
Newsgroups linux.kernel
Subject Re: [PATCH] drm/exynos/dsi: Remove error handling for bridge_node DT parsing
Date 2017-06-13 11:30 +0200
Message-ID <tRQj8-6bD-39@gated-at.bofh.it> (permalink)
References <tQooV-8bH-11@gated-at.bofh.it> <tQooV-8bH-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw



2017년 06월 09일 18:23에 Hoegeun Kwon 이(가) 쓴 글:
> The bridge_node is unnecessary between FIMD and DSIM. If don't remove
> error handling, it will not work between FIMD and DSIM. So remove
> error handling.

Please make sure to describe why bridge_node is unnecessary.
For example,
In case of Exynos SoC, a bridge device such as mDNIe and MIC could be placed between Display Controller and MIPI DSI device but the bridge device is required optionally.

Thanks,
Inki Dae

> 
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> index a11b795..6ee0dac 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> @@ -1651,8 +1651,6 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi)
>  		return ret;
>  
>  	dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_IN, 0);
> -	if (!dsi->bridge_node)
> -		return -EINVAL;
>  
>  	return 0;
>  }
> 

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] drm/exynos/dsi: Remove error handling for bridge_node DT  parsing Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-06-09 11:30 +0200
  Re: [PATCH] drm/exynos/dsi: Remove error handling for bridge_node  DT parsing Inki Dae <inki.dae@samsung.com> - 2017-06-13 11:30 +0200
    Re: [PATCH] drm/exynos/dsi: Remove error handling for bridge_node  DT parsing Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-06-13 12:40 +0200

csiph-web