Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1664591
| From | Alexander Stein <alexander.stein@systec-electronic.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V2 2/2] timer: imx-tpm: add imx tpm timer support |
| Date | 2017-06-13 10:30 +0200 |
| Message-ID | <tRPn3-5Bu-5@gated-at.bofh.it> (permalink) |
| References | <tRPn3-5Bu-7@gated-at.bofh.it> <tRPn3-5Bu-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tuesday 13 June 2017 15:58:45, Dong Aisheng wrote:
> diff --git a/drivers/clocksource/timer-imx-tpm.c
> b/drivers/clocksource/timer-imx-tpm.c new file mode 100644
> index 0000000..940a4f75
> --- /dev/null
> +++ b/drivers/clocksource/timer-imx-tpm.c
> @@ -0,0 +1,227 @@
> [...]
> +static int tpm_set_next_event(unsigned long delta,
> + struct clock_event_device *evt)
> +{
> + unsigned long next, now;
> +
> + next = readl(timer_base + TPM_CNT) + delta;
> + writel(next, timer_base + TPM_C0V);
> + now = readl(timer_base + TPM_CNT);
What about:
> now = readl(timer_base + TPM_CNT);
> next = now + delta;
> writel(next, timer_base + TPM_C0V);
> return 0;
> + return (int)((next - now) <= 0) ? -ETIME : 0;
Can this error actually happen, even with your implementation?
Best regards,
Alexander
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [PATCH V2 2/2] timer: imx-tpm: add imx tpm timer support Alexander Stein <alexander.stein@systec-electronic.com> - 2017-06-13 10:30 +0200 Re: [PATCH V2 2/2] timer: imx-tpm: add imx tpm timer support Dong Aisheng <dongas86@gmail.com> - 2017-06-19 17:40 +0200
csiph-web