RE: [PATCH net-next 1/2] r8152: split rtl8152_resume function

From	Hayes Wang <hayeswang@realtek.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH net-next 1/2] r8152: split rtl8152_resume function
Date	2017-06-13 04:30 +0200
Message-ID	<tRJKG-26m-3@gated-at.bofh.it> (permalink)
References	<tRsTw-8al-9@gated-at.bofh.it> <tRsTw-8al-7@gated-at.bofh.it> <tRwNr-26c-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Oliver Neukum [mailto:oneukum@suse.com]
> Sent: Monday, June 12, 2017 8:33 PM
[...]
> > +               usb_submit_urb(tp->intr_urb, GFP_KERNEL);
> 
> If you ever built a device with included storage, this can deadlock,
> as you may want to wake up a device for memory that is needed to wake
> up a device. Use GFP_NOIO in resume() and reset_resume(), always.

I would change it. Thanks.

Best Regards,
Hayes

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next 1/2] r8152: split rtl8152_resume function Hayes Wang <hayeswang@realtek.com> - 2017-06-12 10:30 +0200
  Re: [PATCH net-next 1/2] r8152: split rtl8152_resume function Oliver Neukum <oneukum@suse.com> - 2017-06-12 14:40 +0200
    RE: [PATCH net-next 1/2] r8152: split rtl8152_resume function Hayes Wang <hayeswang@realtek.com> - 2017-06-13 04:30 +0200

csiph-web