Re: [PATCH v9 07/10] powerpc/perf: PMU functions for Core IMC and hotplugging

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v9 07/10] powerpc/perf: PMU functions for Core IMC and hotplugging
Date	2017-06-13 00:50 +0200
Message-ID	<tRGjM-8du-9@gated-at.bofh.it> (permalink)
References	<tOZsC-2TL-23@gated-at.bofh.it> <tOZsC-2TL-27@gated-at.bofh.it> <tPjB0-7ik-17@gated-at.bofh.it> <tPC0V-2oJ-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 7 Jun 2017, Anju T Sudhakar wrote:
> On Tuesday 06 June 2017 03:39 PM, Thomas Gleixner wrote:
> > On Mon, 5 Jun 2017, Anju T Sudhakar wrote:
> > > +static void cleanup_all_core_imc_memory(struct imc_pmu *pmu_ptr)
> > > +{
> > > +	struct imc_mem_info *ptr = pmu_ptr->mem_info;
> > > +
> > > +	if (!ptr)
> > > +		return;
> > That's pointless.
> 
> No, it is not.  We may end up here from imc_mem_init() when the memory
> allocation for pmu_ptr->mem_info fails. So in that case we can just
> return from here, and kfree wont be called with a NULL pointer.

What's the problem with that. kfree() CAN be called with a NULL pointer. It
has a check already.

Thanks,

	tglx

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v9 07/10] powerpc/perf: PMU functions for Core IMC and  hotplugging Thomas Gleixner <tglx@linutronix.de> - 2017-06-13 00:50 +0200

csiph-web