Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1664206

Re: [PATCH] arm64/dma-mapping: Fix null-pointer check

Show all headers | View raw

On 17-06-10 23:03:54, Russell King - ARM Linux wrote:
> On Sat, Jun 10, 2017 at 12:41:10PM -0700, Olav Haugan wrote:
> > @@ -149,6 +140,11 @@ static void *__dma_alloc(struct device *dev, size_t size,
> >  	bool coherent = is_device_dma_coherent(dev);
>                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> This re-introduces an instance that you say you're getting rid of...
> 

The ARM64 version of is_device_dma_coherent() checks for !dev
already...But anyway I will completely remove the !dev checks in the
alloc/free functions since as Catalin pointed out it is coverted
elsewhere.

-- 
.Olav

The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] arm64/dma-mapping: Fix null-pointer check Olav Haugan <ohaugan@codeaurora.org> - 2017-06-10 21:50 +0200
  Re: [PATCH] arm64/dma-mapping: Fix null-pointer check Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-06-11 00:10 +0200
    Re: [PATCH] arm64/dma-mapping: Fix null-pointer check Olav Haugan <ohaugan@codeaurora.org> - 2017-06-12 22:40 +0200
  Re: [PATCH] arm64/dma-mapping: Fix null-pointer check Catalin Marinas <catalin.marinas@arm.com> - 2017-06-12 14:30 +0200
    Re: [PATCH] arm64/dma-mapping: Fix null-pointer check Olav Haugan <ohaugan@codeaurora.org> - 2017-06-12 22:40 +0200
    Re: [PATCH] arm64/dma-mapping: Fix null-pointer check Olav Haugan <ohaugan@codeaurora.org> - 2017-06-12 23:00 +0200
      Re: [PATCH] arm64/dma-mapping: Fix null-pointer check Catalin Marinas <catalin.marinas@arm.com> - 2017-06-13 11:10 +0200

csiph-web