Re: [PATCH] x86/mce: Always save severity in machine_check_poll

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	"Luck, Tony" <tony.luck@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86/mce: Always save severity in machine_check_poll
Date	Mon, 12 Jun 2017 20:10:01 +0200
Message-ID	<tRBWN-5Ex-5@gated-at.bofh.it> (permalink)
References	<tRBWN-5Ex-7@gated-at.bofh.it>
X-Original-To	Yazen Ghannam <Yazen.Ghannam@amd.com>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.39,334,1493708400"; d="scan'208";a="1159568995"
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	NeoMutt/20170113 (1.7.2)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	17
Organization	linux.* mail to news gateway
X-Original-Cc	linux-edac@vger.kernel.org, Borislav Petkov <bp@suse.de>, x86@kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Mon, 12 Jun 2017 11:07:54 -0700
X-Original-Message-ID	<20170612180753.mjoutdtp3mgpqqvp@intel.com>
X-Original-References	<1497286446-59533-1-git-send-email-Yazen.Ghannam@amd.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1664142

Show key headers only | View raw

On Mon, Jun 12, 2017 at 11:54:06AM -0500, Yazen Ghannam wrote:
> -		severity = mce_severity(&m, mca_cfg.tolerant, NULL, false);
> -
> -		if (severity == MCE_DEFERRED_SEVERITY && mce_is_memory_error(&m))
> -			if (m.status & MCI_STATUS_ADDRV)
> -				m.severity = severity;
> +		m.severity = mce_severity(&m, mca_cfg.tolerant, NULL, false);

So that isn't quite the same. Before we only set m.severity for
memory errors where we had a valid address. Now you unconditionally
set it.

Maybe that's more useful. But it now needs an audit of the code
the registered notifiers to make sure they didn't assume that
severity set meant that this is a memory error.

-Tony

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] x86/mce: Always save severity in machine_check_poll "Luck, Tony" <tony.luck@intel.com> - 2017-06-12 20:10 +0200
  RE: [PATCH] x86/mce: Always save severity in machine_check_poll "Ghannam, Yazen" <Yazen.Ghannam@amd.com> - 2017-06-12 21:00 +0200

csiph-web