Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1663952

[PATCH v3 1/9] gpio: mvebu: fix regmap_update_bits usage

Show all headers | View raw

In some place in the driver regmap_update_bits was misused. Indeed the
last argument is not the value of the bit (or group of bits) itself but
the mask value inside the register.

So when setting the bit N, then the value must be BIT(N) and not 1.

CC: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
CC: Ralph Sennhauser <ralph.sennhauser@gmail.com>
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Tested-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
Tested-by: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
---
 drivers/gpio/gpio-mvebu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
index 4aec8762fdc5..d5939913d310 100644
--- a/drivers/gpio/gpio-mvebu.c
+++ b/drivers/gpio/gpio-mvebu.c
@@ -341,7 +341,7 @@ static int mvebu_gpio_direction_input(struct gpio_chip *chip, unsigned int pin)
 		return ret;
 
 	regmap_update_bits(mvchip->regs, GPIO_IO_CONF_OFF,
-			   BIT(pin), 1);
+			   BIT(pin), BIT(pin));
 
 	return 0;
 }
@@ -503,7 +503,7 @@ static int mvebu_gpio_irq_set_type(struct irq_data *d, unsigned int type)
 	case IRQ_TYPE_EDGE_FALLING:
 	case IRQ_TYPE_LEVEL_LOW:
 		regmap_update_bits(mvchip->regs, GPIO_IN_POL_OFF,
-				   BIT(pin), 1);
+				   BIT(pin), BIT(pin));
 		break;
 	case IRQ_TYPE_EDGE_BOTH: {
 		u32 data_in, in_pol, val;
-- 
git-series 0.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/9] Add support for the pin and gpio controllers on the Marvell Armada 7K/8K Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-06-12 17:40 +0200
  [PATCH v3 2/9] pinctrl: mvebu: remove the offset property for regmap Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-06-12 18:50 +0200
    Re: [PATCH v3 2/9] pinctrl: mvebu: remove the offset property for regmap Linus Walleij <linus.walleij@linaro.org> - 2017-06-16 11:30 +0200
  [PATCH v3 9/9] arm64: dts: marvell: add gpio support for Armada 7K/8K Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-06-12 18:50 +0200
  [PATCH v3 8/9] gpio: mvebu: Add support for the Armada 7K/8K SoCs Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-06-12 18:50 +0200
  [PATCH v3 1/9] gpio: mvebu: fix regmap_update_bits usage Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-06-12 18:50 +0200
    Re: [PATCH v3 1/9] gpio: mvebu: fix regmap_update_bits usage Linus Walleij <linus.walleij@linaro.org> - 2017-06-16 11:20 +0200
  [PATCH v3 5/9] pinctrl: mvebu: add driver for Armada AP806 pinctrl Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-06-12 18:50 +0200
    Re: [PATCH v3 5/9] pinctrl: mvebu: add driver for Armada AP806 pinctrl Linus Walleij <linus.walleij@linaro.org> - 2017-06-16 11:30 +0200
  [PATCH v3 3/9] pinctrl: avoid PLAT_ORION dependency Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-06-12 18:50 +0200
    Re: [PATCH v3 3/9] pinctrl: avoid PLAT_ORION dependency Linus Walleij <linus.walleij@linaro.org> - 2017-06-16 11:30 +0200
  [PATCH v3 7/9] arm64: dts: marvell: add pinctrl support for Armada 7K/8K Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-06-12 18:50 +0200
  [PATCH v3 4/9] arm64: marvell: enable the Armada 7K/8K pinctrl driver Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-06-12 18:50 +0200
    Re: [PATCH v3 4/9] arm64: marvell: enable the Armada 7K/8K pinctrl driver Linus Walleij <linus.walleij@linaro.org> - 2017-06-16 11:30 +0200
  [PATCH v3 6/9] pinctrl: mvebu: add driver for Armada CP110 pinctrl Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-06-12 18:50 +0200
    Re: [PATCH v3 6/9] pinctrl: mvebu: add driver for Armada CP110 pinctrl Linus Walleij <linus.walleij@linaro.org> - 2017-06-16 11:30 +0200
    Re: [PATCH v3 6/9] pinctrl: mvebu: add driver for Armada CP110 pinctrl Linus Walleij <linus.walleij@linaro.org> - 2017-06-16 11:30 +0200

csiph-web