Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1663838

Re: [net-next] net: phy: marvell: Show complete link partner advertising

Show all headers | View raw

On 06/12/2017 05:54 AM, Thomas Bogendoerfer wrote:
> From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> 
> Give back all modes advertised by the link partner. This change brings
> the marvell phy driver in line with all other phy drivers.
> 
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>

I thought Russell had a similar patch but I can't find it applied in
net-next, so:

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

drivers/net/phy/lxt.c has a similar pattern that would be worth fixing too.

> ---
>  drivers/net/phy/marvell.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
> index 4c5246fed69b..8400403b3f62 100644
> --- a/drivers/net/phy/marvell.c
> +++ b/drivers/net/phy/marvell.c
> @@ -1139,7 +1139,6 @@ static int marvell_read_status_page_an(struct phy_device *phydev,
>  	int status;
>  	int lpa;
>  	int lpagb;
> -	int adv;
>  
>  	status = phy_read(phydev, MII_M1011_PHY_STATUS);
>  	if (status < 0)
> @@ -1153,12 +1152,6 @@ static int marvell_read_status_page_an(struct phy_device *phydev,
>  	if (lpagb < 0)
>  		return lpagb;
>  
> -	adv = phy_read(phydev, MII_ADVERTISE);
> -	if (adv < 0)
> -		return adv;
> -
> -	lpa &= adv;
> -
>  	if (status & MII_M1011_PHY_STATUS_FULLDUPLEX)
>  		phydev->duplex = DUPLEX_FULL;
>  	else
> 


-- 
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[net-next] net: phy: marvell: Show complete link partner advertising Thomas Bogendoerfer <tsbogend@alpha.franken.de> - 2017-06-12 15:40 +0200
  Re: [net-next] net: phy: marvell: Show complete link partner  advertising David Miller <davem@davemloft.net> - 2017-06-12 18:10 +0200
  Re: [net-next] net: phy: marvell: Show complete link partner  advertising Florian Fainelli <f.fainelli@gmail.com> - 2017-06-12 18:10 +0200
    Re: [net-next] net: phy: marvell: Show complete link partner  advertising Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-06-12 18:20 +0200
    Re: [net-next] net: phy: marvell: Show complete link partner  advertising Tom Bogendoerfer <tsbogend@alpha.franken.de> - 2017-06-13 10:40 +0200

csiph-web