Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1663068

[PATCH] f2fs: Fix a return value in case of error in 'f2fs_fill_super'

Show all headers | View raw

err must be set to -ENOMEM, otherwise we return 0.

Fixes: a912b54d3aaa0 ("f2fs: split bio cache")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 fs/f2fs/super.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 5be27eacea99..38f1624ac5dc 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -1976,8 +1976,10 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent)
 
 		sbi->write_io[i] = kmalloc(n * sizeof(struct f2fs_bio_info),
 								GFP_KERNEL);
-		if (!sbi->write_io[i])
+		if (!sbi->write_io[i]) {
+			err = -ENOMEM;
 			goto free_options;
+		}
 
 		for (j = HOT; j < n; j++) {
 			init_rwsem(&sbi->write_io[i][j].io_rwsem);
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] f2fs: Fix a return value in case of error in 'f2fs_fill_super' Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-06-11 09:30 +0200
  Re: [PATCH] f2fs: Fix a return value in case of error in  'f2fs_fill_super' Chao Yu <yuchao0@huawei.com> - 2017-06-12 13:00 +0200

csiph-web