Re: [PATCH v2] firmware: fix sending -ERESTARTSYS due to signal on fallback

From	"Luis R. Rodriguez" <mcgrof@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] firmware: fix sending -ERESTARTSYS due to signal on fallback
Date	2017-06-09 23:30 +0200
Message-ID	<tQzDH-6HJ-9@gated-at.bofh.it> (permalink)
References	(8 earlier) <tPx1f-7Cp-5@gated-at.bofh.it> <tPBex-1PL-7@gated-at.bofh.it> <tPCDE-2Td-5@gated-at.bofh.it> <tQgKJ-3le-3@gated-at.bofh.it> <tQh45-3sH-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 8, 2017 at 6:33 PM, Luis R. Rodriguez <mcgrof@kernel.org> wrote:
> On Thu, Jun 8, 2017 at 6:14 PM, Andy Lutomirski <luto@kernel.org> wrote:
>> That's what I meant, but I said it unclearly.  I meant that, if we're
>> going to start allowing interruption, we would need to audit all the
>> callers.  Ugh.
>
> There are actually two audits worth evaluating if what we've concluded
> is fair game:
>
>   a) firmware sync calls on interruptible paths
>   b) use of swait / old interruptible waits on sysfs paths

And as I noted in the other thread -- another possible issue could be
any swait / interruptable wait on init or probe. Provided any child
completes and the kernel code for wait handler does abort, that
request would be terminated. This could for instance happen at bootup
as modules load and any child from the loader terminates.

We already have Coccinelle grammar to hunt for "though shall not
request firmware on init or probe", such SmPL grammar could be in turn
be repruposed to hunt for these types of conditions.

  Luis

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] firmware: fix sending -ERESTARTSYS due to signal on fallback Andy Lutomirski <luto@kernel.org> - 2017-06-09 03:20 +0200
  Re: [PATCH v2] firmware: fix sending -ERESTARTSYS due to signal on fallback "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-06-09 03:40 +0200
    Re: [PATCH v2] firmware: fix sending -ERESTARTSYS due to signal on fallback "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-06-09 23:30 +0200

csiph-web