Re: [PATCH] VFS: Differentiate mount flags (MS_*) from internal superblock flags

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] VFS: Differentiate mount flags (MS_*) from internal superblock flags
Date	2017-06-09 18:10 +0200
Message-ID	<tQuE2-3IK-21@gated-at.bofh.it> (permalink)
References	<tQub0-3k4-15@gated-at.bofh.it> <tQtHY-38t-11@gated-at.bofh.it> <tQub0-3k4-15@gated-at.bofh.it>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

Jeff Layton <jlayton@redhat.com> wrote:

> I guess you mean stuff like affs_fill_super which does:
> 
>     sb->s_flags |= MS_NODEV | MS_NOSUID;
> 
> It seems like it's doing that too late to be useful.

Actually, after the change, it seems nothing actually tests SB_NOSUID,
SB_NODEV or SB_NOEXEC, so those bits should probably be removed.

I also wonder if the internal MS_ flags (eg. MS_SUBMOUNT) should be removed
from the UAPI header.

David

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] VFS: Differentiate mount flags (MS_*) from internal  superblock flags Jeff Layton <jlayton@redhat.com> - 2017-06-09 17:40 +0200
  Re: [PATCH] VFS: Differentiate mount flags (MS_*) from internal superblock flags David Howells <dhowells@redhat.com> - 2017-06-09 18:10 +0200

csiph-web