RE: [PATCH] Drivers: unisys: visorhba - style fix

From	"Kershner, David A" <David.Kershner@unisys.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH] Drivers: unisys: visorhba - style fix
Date	2017-06-09 16:40 +0200
Message-ID	<tQteV-2JK-1@gated-at.bofh.it> (permalink)
References	<tQkv0-5Np-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> -----Original Message-----
> From: Derek Robson [mailto:robsonde@gmail.com]
> Sent: Friday, June 9, 2017 1:16 AM
> To: Kershner, David A <David.Kershner@unisys.com>;
> gregkh@linuxfoundation.org; Binder, David Anthony
> <David.Binder@unisys.com>; Sell, Timothy C <Timothy.Sell@unisys.com>;
> Wadgaonkar, Sameer Laxmikant <Sameer.Wadgaonkar@unisys.com>;
> Thompson, Bryan E. <bryan.thompson@unisys.com>; robsonde@gmail.com
> Cc: *S-Par-Maintainer <SParMaintainer@unisys.com>;
> devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] Drivers: unisys: visorhba - style fix
> 
> Fixed style of permissions to octal.
> Found using checkpatch
> 
> Signed-off-by: Derek Robson <robsonde@gmail.com>

Acked-by: David Kershner <david.kershner@unisys.com>

> ---
>  drivers/staging/unisys/visorhba/visorhba_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
> b/drivers/staging/unisys/visorhba/visorhba_main.c
> index 2fd31c9762c6..a6e7a6bbc428 100644
> --- a/drivers/staging/unisys/visorhba/visorhba_main.c
> +++ b/drivers/staging/unisys/visorhba/visorhba_main.c
> @@ -1090,7 +1090,7 @@ static int visorhba_probe(struct visor_device *dev)
>  		goto err_scsi_remove_host;
>  	}
>  	devdata->debugfs_info =
> -		debugfs_create_file("info", S_IRUSR | S_IRGRP,
> +		debugfs_create_file("info", 0440,
>  				    devdata->debugfs_dir, devdata,
>  				    &info_debugfs_fops);
>  	if (!devdata->debugfs_info) {
> --
> 2.13.0

Thread

[PATCH] Drivers: unisys: visorhba - style fix Derek Robson <robsonde@gmail.com> - 2017-06-09 07:20 +0200
  RE: [PATCH] Drivers: unisys: visorhba - style fix "Kershner, David A" <David.Kershner@unisys.com> - 2017-06-09 16:40 +0200
  Re: [PATCH] Drivers: unisys: visorhba - style fix Dan Carpenter <dan.carpenter@oracle.com> - 2017-06-10 13:30 +0200

csiph-web