Re: [PATCH tip/core/rcu 0/88] Commits for 4.13

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH tip/core/rcu 0/88] Commits for 4.13
Date	2017-06-09 16:00 +0200
Message-ID	<tQsCf-2cm-43@gated-at.bofh.it> (permalink)
References	<tL8Xv-5iU-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 25 May 2017 14:59:34 -0700
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:

> Hello!
> 
> This rather long series mostly removes unused features, shrinks the
> include/linux/rcupdate.h file's .i intermediate-output size, updates
> rcutorture testing, and supplies miscellaneous fixes.  Branching proved
> impractical due to the large footprint of many of the commits, hence the
> long linear series.  On the other hand, this series's diffstat summary
> line is as follows:
> 
>  87 files changed, 1745 insertions(+), 4389 deletions(-)
>

Hi Paul,

88 patches is quite overwhelming. I would recommend breaking something
like this up into multiple patch series with different topics. One
could be the ones that affect seftests only. Another for srcu, another
for documentation, etc.

When one gets 88 patches and sees that it's a hodge podge of various
parts of RCU, they tend to just ignore the entire series. If you want
reviewers, I strongly recommend breaking it down nicer so that those
that are interested in only parts of RCU will be more likely to review
the patches. Otherwise, people will just say "I don't have time to sort
through all this to find what I'm interested in reviewing", and skip
the entire series.

Thanks!

-- Steve

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH tip/core/rcu 0/88] Commits for 4.13 Steven Rostedt <rostedt@goodmis.org> - 2017-06-09 16:00 +0200
  Re: [PATCH tip/core/rcu 0/88] Commits for 4.13 "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-06-09 18:30 +0200
    Re: [PATCH tip/core/rcu 0/88] Commits for 4.13 Steven Rostedt <rostedt@goodmis.org> - 2017-06-09 18:40 +0200
      Re: [PATCH tip/core/rcu 0/88] Commits for 4.13 "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-06-09 19:30 +0200
        Re: [PATCH tip/core/rcu 0/88] Commits for 4.13 Steven Rostedt <rostedt@goodmis.org> - 2017-06-09 19:40 +0200
          Re: [PATCH tip/core/rcu 0/88] Commits for 4.13 "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-06-09 20:00 +0200
            Re: [PATCH tip/core/rcu 0/88] Commits for 4.13 "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-06-09 20:10 +0200

csiph-web