Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1662407
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next v2 1/7] net: dsa: mv888e6xxx: do not use netdev printing |
| Date | 2017-06-09 15:20 +0200 |
| Message-ID | <tQrZx-1Zf-21@gated-at.bofh.it> (permalink) |
| References | <tQefT-1I1-3@gated-at.bofh.it> <tQefU-1I1-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jun 08, 2017 at 06:34:08PM -0400, Vivien Didelot wrote:
> The mv888e6xxx driver accesses a port's netdev mostly for printing.
>
> This is bad for 2 reasons: DSA and CPU ports do not have a netdev
> pointer; it doesn't give us a correct picture of why a DSA driver might
> need to access a port's netdev.
>
> Instead simply use dev_* printing functions with chip->dev (or ds->dev
> depending on the scope, both guaranteed to exist), with a p%d prefix for
> the target port.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net-next v2 0/7] net: dsa: mv88e6xxx: ops cosmetics Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-06-09 00:40 +0200
[PATCH net-next v2 1/7] net: dsa: mv888e6xxx: do not use netdev printing Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-06-09 00:40 +0200
Re: [PATCH net-next v2 1/7] net: dsa: mv888e6xxx: do not use netdev printing Andrew Lunn <andrew@lunn.ch> - 2017-06-09 15:20 +0200
[PATCH net-next v2 6/7] net: dsa: mv88e6xxx: rework jumbo size operation Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-06-09 00:40 +0200
[PATCH net-next v2 7/7] net: dsa: mv88e6xxx: prefix PHY macros Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-06-09 00:40 +0200
[PATCH net-next v2 5/7] net: dsa: mv88e6xxx: rework pause limit operation Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-06-09 00:40 +0200
Re: [PATCH net-next v2 0/7] net: dsa: mv88e6xxx: ops cosmetics David Miller <davem@davemloft.net> - 2017-06-09 18:20 +0200
csiph-web