Re: [PATCH] arm64: ftrace: fix building without CONFIG_MODULES

From	Will Deacon <will.deacon@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] arm64: ftrace: fix building without CONFIG_MODULES
Date	2017-06-09 13:40 +0200
Message-ID	<tQqqJ-V3-7@gated-at.bofh.it> (permalink)
References	<tQpl0-k7-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Arnd,

On Fri, Jun 09, 2017 at 12:27:06PM +0200, Arnd Bergmann wrote:
> When CONFIG_MODULES is disabled, we cannot dereference a module pointer:
> 
> arch/arm64/kernel/ftrace.c: In function 'ftrace_make_call':
> arch/arm64/kernel/ftrace.c:107:36: error: dereferencing pointer to incomplete type 'struct module'
>    trampoline = (unsigned long *)mod->arch.ftrace_trampoline;
> 
> Also, the within_module() function is not defined:
> 
> arch/arm64/kernel/ftrace.c: In function 'ftrace_make_nop':
> arch/arm64/kernel/ftrace.c:171:8: error: implicit declaration of function 'within_module'; did you mean 'init_module'? [-Werror=implicit-function-declaration]
> 
> This addresses both by adding the appropriate stubs.
> 
> Fixes: e71a4e1bebaf ("arm64: ftrace: add support for far branches to dynamic ftrace")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  arch/arm64/include/asm/module.h | 6 ++++++
>  arch/arm64/kernel/ftrace.c      | 2 +-
>  include/linux/module.h          | 5 +++++
>  3 files changed, 12 insertions(+), 1 deletion(-)

I can't seem to reproduce this simply by disabling MODULES in defconfig.
Could you share your .config, please?

Will

Thread

[PATCH] arm64: ftrace: fix building without CONFIG_MODULES Arnd Bergmann <arnd@arndb.de> - 2017-06-09 12:30 +0200
  Re: [PATCH] arm64: ftrace: fix building without CONFIG_MODULES Will Deacon <will.deacon@arm.com> - 2017-06-09 13:40 +0200
    Re: [PATCH] arm64: ftrace: fix building without CONFIG_MODULES Arnd Bergmann <arnd@arndb.de> - 2017-06-09 21:00 +0200
      Re: [PATCH] arm64: ftrace: fix building without CONFIG_MODULES Will Deacon <will.deacon@arm.com> - 2017-06-12 14:50 +0200
        Re: [PATCH] arm64: ftrace: fix building without CONFIG_MODULES Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-06-12 15:10 +0200
        Re: [PATCH] arm64: ftrace: fix building without CONFIG_MODULES Arnd Bergmann <arnd@arndb.de> - 2017-06-12 16:30 +0200

csiph-web