Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1662362

[PATCH] drivers: block: correct brackets

Show all headers | View raw

GCC complained on linux-next about

drivers/block/loop.c:1149:3: warning: this ‘if’ clause does not guard...
[-Wmisleading-indentation]
   if (figure_loop_size(lo, info->lo_offset, info->lo_sizelimit,
   ^~
drivers/block/loop.c:1152:4: note: ...this statement, but the latter is
misleadingly indented as if it is guarded by the ‘if’
    goto exit;

This adjustes the brackets to the inner if.

Fixes: f2c6df7dbf9a ("loop: support 4k physical blocksize")
Signed-off-by: Seraphime Kirkovski <kirkseraph@gmail.com>
---
 The patch was made against linux-next.

 drivers/block/loop.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 4d376c10a97a..e288fb30100f 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1147,10 +1147,11 @@ loop_set_status(struct loop_device *lo, const struct loop_info64 *info)
 	    ((lo->lo_flags & LO_FLAGS_BLOCKSIZE) &&
 	     lo->lo_logical_blocksize != LO_INFO_BLOCKSIZE(info))) {
 		if (figure_loop_size(lo, info->lo_offset, info->lo_sizelimit,
-				     LO_INFO_BLOCKSIZE(info)))
+				     LO_INFO_BLOCKSIZE(info))) {
 			err = -EFBIG;
 			goto exit;
 		}
+	}
 
 	loop_config_discard(lo);
 
-- 
2.11.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] drivers: block: correct brackets Seraphime Kirkovski <kirkseraph@gmail.com> - 2017-06-09 14:10 +0200

csiph-web